Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is there a need for Torch implementation of STFT and MelSpectrogram? #16

Open
brihijoshi opened this issue Mar 16, 2020 · 1 comment

Comments

@brihijoshi
Copy link

Hi Jong,
Thank you for such a useful implementation! Sorry for a silly doubt, but I am a beginner in MIR and working with Onsets and Frames for a project of mine.

Looking at the STFT and Mel Spectrogram classes, it doesn't seem (and there possibly isn't a need) that they are 'learnable'. I am a little confused as to why is there a need for a Torch implementation for STFT and Mel Spectrogram? Is it not possible to use librosa implementations for the same?

Thanks!

@jongwook
Copy link
Owner

Hi, those were in order to perform Mel spectrogram calculation in GPU, rather than in CPU (librosa), hoping it to be faster. Ase you said, the filters in those modules are not learnable because we used register_buffer instead of nn.Parameter. Those were adapted from NVIDIA's Tacotron2 code, and similar modules exist in torchaudio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants