Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neos9 compatibility #26

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Neos9 compatibility #26

wants to merge 3 commits into from

Conversation

so-grimm
Copy link

@so-grimm so-grimm commented Mar 13, 2024 •
edited
Loading

What does this package do:

  • pulls preview images from youtube and vimeo videos and saves them as a neos asset -> this way it can show the preview image before the user accepted the data privacy agreement and before the video is loaded
  • get metadata for the video assets and saves them into properties
  • replace iframe placeholders with videos once they're allowed to be loaded
  • create the tags for audio and video with all the right data-attributes

ToDos:

  • refactor Utility class because we can't set properties the way we used to in Neos 8 (start with this!)
  • refactor services to remove dependency loops
  • make code Neos 9 compatible

so-grimm added 3 commits March 11, 2024 20:10
@so-grimm
Adjust requirements to allow Neos 9
91af4c9
@so-grimm
Add Neos 9 compatible versions for carbon/fileloader, `carbon/notif…
c2be025 
…ication` and `sitegeist/slipstream`
@so-grimm
TASK: require Neos 9 compatible versions of dependencies and remove n…
1590bdc 
…eos version <9.0

- require `carbon/notification: ^3.0`
- require `sitegeist/slipstream: ^2.1.7`
- set minimum requirement for `neos/neos` to `^9.0 || dev-master`
- set minimum requirement for `neos/fusion-afx` to `^9.0 || dev-master`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@so-grimm