From b67936ee3a2e7c9675beea60ba62721ecd18134c Mon Sep 17 00:00:00 2001 From: Jon Sagara Date: Sun, 19 Nov 2023 11:10:18 -0800 Subject: [PATCH] Timestamp does NOT need to be nullable; the implementing class just needs to mark the property as a [Timestamp]. Removed explicit SourceLink package references from all projects. --- Directory.Build.props | 2 +- src/Sagara.Core.AspNetCore/Sagara.Core.AspNetCore.csproj | 7 +------ src/Sagara.Core.Caching/Sagara.Core.Caching.csproj | 4 ---- src/Sagara.Core.Data/Models/Entity.cs | 2 +- src/Sagara.Core.Data/Models/IEntity.cs | 2 +- src/Sagara.Core.Data/Sagara.Core.Data.csproj | 4 ---- .../Sagara.Core.Logging.Serilog.csproj | 4 ---- src/Sagara.Core/Sagara.Core.csproj | 4 ---- 8 files changed, 4 insertions(+), 25 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 3221c9a..833d3c8 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -5,7 +5,7 @@ 12.0 - 2.0.7 + 2.0.8 2.0.0 2.0.0 Jon Sagara diff --git a/src/Sagara.Core.AspNetCore/Sagara.Core.AspNetCore.csproj b/src/Sagara.Core.AspNetCore/Sagara.Core.AspNetCore.csproj index 5633836..7b98dd7 100644 --- a/src/Sagara.Core.AspNetCore/Sagara.Core.AspNetCore.csproj +++ b/src/Sagara.Core.AspNetCore/Sagara.Core.AspNetCore.csproj @@ -28,12 +28,7 @@ - - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - - + diff --git a/src/Sagara.Core.Caching/Sagara.Core.Caching.csproj b/src/Sagara.Core.Caching/Sagara.Core.Caching.csproj index 2bf7ace..d01ce26 100644 --- a/src/Sagara.Core.Caching/Sagara.Core.Caching.csproj +++ b/src/Sagara.Core.Caching/Sagara.Core.Caching.csproj @@ -30,10 +30,6 @@ - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - diff --git a/src/Sagara.Core.Data/Models/Entity.cs b/src/Sagara.Core.Data/Models/Entity.cs index b4a7775..2a363c0 100644 --- a/src/Sagara.Core.Data/Models/Entity.cs +++ b/src/Sagara.Core.Data/Models/Entity.cs @@ -28,7 +28,7 @@ public abstract class Entity : IEntity [Timestamp] // Required by EF Core for SQL Server Timestamp functionality. #pragma warning disable CA1819 // Properties should not return arrays - public byte[]? Timestamp { get; set; } + public byte[] Timestamp { get; set; } = null!; #pragma warning restore CA1819 // Properties should not return arrays /// diff --git a/src/Sagara.Core.Data/Models/IEntity.cs b/src/Sagara.Core.Data/Models/IEntity.cs index ae145bc..2ad6329 100644 --- a/src/Sagara.Core.Data/Models/IEntity.cs +++ b/src/Sagara.Core.Data/Models/IEntity.cs @@ -34,7 +34,7 @@ public interface IEntity /// // Justification: Required by EF Core for the SQL Server timestamp to function. #pragma warning disable CA1819 // Properties should not return arrays - byte[]? Timestamp { get; set; } + byte[] Timestamp { get; set; } #pragma warning restore CA1819 // Properties should not return arrays } diff --git a/src/Sagara.Core.Data/Sagara.Core.Data.csproj b/src/Sagara.Core.Data/Sagara.Core.Data.csproj index 8d314b6..e9ff57a 100644 --- a/src/Sagara.Core.Data/Sagara.Core.Data.csproj +++ b/src/Sagara.Core.Data/Sagara.Core.Data.csproj @@ -31,10 +31,6 @@ - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - diff --git a/src/Sagara.Core.Logging.Serilog/Sagara.Core.Logging.Serilog.csproj b/src/Sagara.Core.Logging.Serilog/Sagara.Core.Logging.Serilog.csproj index 07a7e34..aff7b2d 100644 --- a/src/Sagara.Core.Logging.Serilog/Sagara.Core.Logging.Serilog.csproj +++ b/src/Sagara.Core.Logging.Serilog/Sagara.Core.Logging.Serilog.csproj @@ -32,10 +32,6 @@ - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - diff --git a/src/Sagara.Core/Sagara.Core.csproj b/src/Sagara.Core/Sagara.Core.csproj index 16b15b6..8f5b732 100644 --- a/src/Sagara.Core/Sagara.Core.csproj +++ b/src/Sagara.Core/Sagara.Core.csproj @@ -30,10 +30,6 @@ -