Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dotnet framework4.8 #517

Open
Daniel12321 opened this issue Jul 12, 2024 · 12 comments
Open

Support for dotnet framework4.8 #517

Daniel12321 opened this issue Jul 12, 2024 · 12 comments
Assignees

Comments

@Daniel12321
Copy link

We are using Insight Database in a dotnet4.8 framework project. Is it possible to get support for this version in 8.0.1 and up?

  • Dotnet version: [dotnet framework 4.8]
  • Database: [SQL Server]
  • Library version: [8.0.1]
@jonwagner
Copy link
Owner

Ah - I didn't realize that Microsoft was keeping net48 alive with versions of the Windows OS.

Unfortunately, I currently don't have regular access to a Windows machine for builds, so it will take me some time to get that set up again. But Insight v6 and v8 are mostly identical so you can use that for now.

@jfrank14
Copy link

jfrank14 commented Sep 6, 2024

+1 for this. I'm using .net framework 4.8 as well and nuget is nagging me to upgrade but I can't, because of this issue.

@jonwagner
Copy link
Owner

I'm going to try this to clean up the build process:

https://stu.dev/dotnet-framework-reference-assemblies-via-nuget/

@jonwagner
Copy link
Owner

@jfrank14 @Daniel12321

can one of you try the build off of this branch:

https://github.com/jonwagner/Insight.Database/compare/net48

@jonwagner jonwagner self-assigned this Sep 12, 2024
@jfrank14
Copy link

I checked out this branch and it built successfully. Was there anything else you wanted to know about the build?

@jonwagner
Copy link
Owner

I know the branch builds but I don't have a .net 4.8 project to test it in. it would be great just to get a sanity check that it works there.

@jfrank14
Copy link

Is it enough to replace the Insight* files in the bin folder? The only way I know there's an issue is that NuGet won't let me upgrade, but to test that would require publishing to NuGet.

@jonwagner
Copy link
Owner

jonwagner commented Sep 12, 2024 via email

@jonwagner
Copy link
Owner

actually...I can do a prerelease build and you can test it.

@jonwagner
Copy link
Owner

ok... I pushed version 8.0.2-beta1. That should contain the net48 versions. LMK if that works and I'll convert it to a release build.

@jfrank14
Copy link

I just tried that beta version on a 4.8 project and it upgraded. I haven't tried to run it yet, because there are some other reference issues, but does knowing that NuGet worked answer enough of the question for you, or do you also want confirmation that it runs without error?

@jfrank14
Copy link

I just tried that beta version on a 4.8 project and it upgraded. I haven't tried to run it yet, because there are some other reference issues, but does knowing that NuGet worked answer enough of the question for you, or do you want confirmation that it runs without error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants