Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop use of jQuery, as it lead to failed test in Joomla 4 #215

Open
Fedik opened this issue Mar 21, 2021 · 1 comment
Open

Drop use of jQuery, as it lead to failed test in Joomla 4 #215

Fedik opened this issue Mar 21, 2021 · 1 comment

Comments

@Fedik
Copy link

Fedik commented Mar 21, 2021

Drop use of jQuery, as it leads to failed test in Joomla 4

Example this section

public function selectOptionInChosenByIdUsingJs($selectId, $option)
{
$option = trim($option);
$this->executeJS("jQuery('#$selectId option').filter(function(){ return this.text.trim() === \"$option\" }).prop('selected', true);");
$this->executeJS("jQuery('#$selectId').trigger('liszt:updated').trigger('chosen:updated');");
$this->executeJS("jQuery('#$selectId').trigger('change');");
// Give time to Chosen to update
$this->wait(1);
}

Related discussion joomla/joomla-cms#32766
Example of failed test :
joomla/joomla-cms#32707
https://ci.joomla.org/joomla/joomla-cms/40772/1/22

@laoneo
Copy link
Contributor

laoneo commented Mar 21, 2022

As we do not use chosen anymore in 4, the whole function should be deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants