-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Packages and JPMS #16
Comments
Thanks for the heads up, that is definitely non intentional. |
Thanks for the quick response! I also filed an issue for SimpleFramework: ngallagher/simpleframework#24 |
Here's where we are on this (2018-01-21): I pushed a fix for this to Master, but it started failing Travis. Turns out that was because Travis doesn't support the oracle jdk7 any more. I tried switching to openjdk7 and also oraclejdk8 - but both cause an intermittent unit test failure, I think caused by XmlOutputStreamFilter in the simple module. (Update) Meanwhile - @AugustNagro - can you confirm that the change to package structure actually fixes the issue you report here - and close as appropriate? Many thanks |
Working well, thanks! Would it be possible to add Automatic Module names as well? For example:
|
Yes, happy to do that, would you like to create a pull request against branch Many thanks! |
Closing as reported that it works now ... |
Because KeePassJava2 has split packages (org.linguafranca.pwdb.kdbx in both KeePassJava2.kdbx and KeePassJava2.simple), the library can't be used with the Java 9 module system.
Would there be any interest in refactoring? For reference: https://stackoverflow.com/a/42358212
Regards,
August
The text was updated successfully, but these errors were encountered: