Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Packages and JPMS #16

Closed
AugustNagro opened this issue Jan 18, 2018 · 6 comments
Closed

Split Packages and JPMS #16

AugustNagro opened this issue Jan 18, 2018 · 6 comments

Comments

@AugustNagro
Copy link
Contributor

Because KeePassJava2 has split packages (org.linguafranca.pwdb.kdbx in both KeePassJava2.kdbx and KeePassJava2.simple), the library can't be used with the Java 9 module system.

Would there be any interest in refactoring? For reference: https://stackoverflow.com/a/42358212

Regards,

August

@jorabin
Copy link
Owner

jorabin commented Jan 20, 2018

Thanks for the heads up, that is definitely non intentional.

@AugustNagro
Copy link
Contributor Author

Thanks for the quick response!

I also filed an issue for SimpleFramework: ngallagher/simpleframework#24

@jorabin
Copy link
Owner

jorabin commented Jan 21, 2018

Here's where we are on this (2018-01-21):

I pushed a fix for this to Master, but it started failing Travis. Turns out that was because Travis doesn't support the oracle jdk7 any more. I tried switching to openjdk7 and also oraclejdk8 - but both cause an intermittent unit test failure, I think caused by XmlOutputStreamFilter in the simple module.

(Update)
Fix for XmlOutputStreamFilter now pushed and all seems to test correctly on Travis. I'll get on with making a new release pushing to maven central etc.

Meanwhile - @AugustNagro - can you confirm that the change to package structure actually fixes the issue you report here - and close as appropriate?

Many thanks

@AugustNagro
Copy link
Contributor Author

Working well, thanks!

Would it be possible to add Automatic Module names as well? For example:

  <manifestEntries>
    <Automatic-Module-Name>org.linguafranca.pwdb.KeePassJava2.dom</Automatic-Module-Name>
  </manifestEntries>

@jorabin
Copy link
Owner

jorabin commented Jan 22, 2018

Yes, happy to do that, would you like to create a pull request against branch develop for that?

Many thanks!

@jorabin
Copy link
Owner

jorabin commented Jan 23, 2018

Closing as reported that it works now ...

@jorabin jorabin closed this as completed Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants