Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with React-Native 0.52 #59

Open
romanlv opened this issue Jan 30, 2018 · 4 comments
Open

Fails to build with React-Native 0.52 #59

romanlv opened this issue Jan 30, 2018 · 4 comments

Comments

@romanlv
Copy link

romanlv commented Jan 30, 2018

react-native run-android gives

:CrosswalkWebView:incrementalReleaseJavaCompilationSafeguard UP-TO-DATE
:CrosswalkWebView:compileReleaseJavaWithJavac
:CrosswalkWebView:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
/Users/user/dev/tests/crosswalk-test/node_modules/react-native-webview-crosswalk/src/main/java/com/jordansexton/react/crosswalk/webview/CrosswalkWebViewPackage.java:26: error: method does not override or implement a method from a supertype
    @Override
    ^
Note: /Users/user/dev/tests/crosswalk-test/node_modules/react-native-webview-crosswalk/src/main/java/com/jordansexton/react/crosswalk/webview/CrosswalkWebViewGroupManager.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/user/dev/tests/crosswalk-test/node_modules/react-native-webview-crosswalk/src/main/java/com/jordansexton/react/crosswalk/webview/CrosswalkWebViewGroupManager.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
:CrosswalkWebView:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':CrosswalkWebView:compileReleaseJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

Problem can be reproduced in demo project

@ajRiverav
Copy link

ajRiverav commented Mar 4, 2018

I have the same problem (0.5.0 and RN 0.51.0)

edit: I just downgraded to 0.4.0, and still have the same issue, so it must have been something else. @romanlv can you confirm it happens on 0.4.0 with + your code?

@maksimis
Copy link

I have the same problem. What version rnwc, react-native, react i should use?

@vartana
Copy link

vartana commented Apr 16, 2018

+1

@romanlv
Copy link
Author

romanlv commented Apr 16, 2018

btw, Android 4.4 (KitKat), the WebView component is based on the Chromium so you may not need this implementation at all. It is not the case for iOS, where wkwebview has much better performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants