Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility for 5.6 #3

Open
zeroedin opened this issue Nov 6, 2012 · 6 comments
Open

Compatibility for 5.6 #3

zeroedin opened this issue Nov 6, 2012 · 6 comments

Comments

@zeroedin
Copy link

zeroedin commented Nov 6, 2012

Is this in the works by any chance?

@jordanlev
Copy link
Owner

What's the issue you're having with 5.6?

On Nov 6, 2012, at 12:21 AM, Steven Spriggs [email protected] wrote:

Is this in the works by any chance?


Reply to this email directly or view it on GitHub.

@zeroedin
Copy link
Author

zeroedin commented Nov 6, 2012

I believe there is an issue in $this->installPageLinkAttribute($pkg);

I just removed the full installPageLink function and got most everything to work to my needs.

@jordanlev
Copy link
Owner

I just ran a test with Concrete5.6.0.2 and didn't seem to have any problems. Your description is very vague -- can you please provide some more details about what the exact error you're seeing is, where you see it, what point in the process it happens in, if it prevents you from doing certain things (installing the package, adding a block, choosing images, etc. etc?)?

@zeroedin
Copy link
Author

zeroedin commented Nov 7, 2012

I'll have to go back through setup again to revisit the error. After I do so ill post the exact error if I reproduce it.

@hkalancheung
Copy link

Hi, I can't get into the "File Sets" dialog from the file manager. It makes me cannot change the images order.

There is no "drop down" triangle in the bar. I checked with the permission and everything, it still doesn't show up, even with admin access. Please help.
screen shot 2014-10-13 at 12 51 43 pm

@jordanlev
Copy link
Owner

@hkalancheung , my first guess is a conflict with your theme CSS or JS. Try adding a regular "file" or "image" block to a page (that doesn't already have the image gallery block on it), and when adding one of those blocks click on the file selector... does the file manager popup exhibit the same behavior then as well? If so, it's a general problem you'll need to figure out with your theme. You can use your browser's dev tools to look for errors or inspect the css of the dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants