Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incremental compilation optimization when raw expressions change. #23

Open
jordwalke opened this issue Nov 1, 2019 · 1 comment

Comments

@jordwalke
Copy link
Owner

The --use-hashing feature works well except when the only thing you change in an input source is something like a "raw expression". I believe this is because those raw expressions may be embedded in the "global data" section of the bytecode libraries, but incremental compilation hashes the individual sub-modules in a library. I believe the fix is to recompile everything in the library if anything in the shared data segment changes. There may be other issues with recompilation here too

@jordwalke
Copy link
Owner Author

Also, need to take into account the hashes of the imported interfaces - at the module level, not cma level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant