Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retina --css-template broken #150

Closed
ghost opened this issue Apr 11, 2014 · 1 comment
Closed

Retina --css-template broken #150

ghost opened this issue Apr 11, 2014 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 11, 2014

@jorgebastida @randyrollog
So in glue 0.9.2 and glue 0.9.4 retina doesn't work with --css-template you get a CSS parsing error and glue just errors out and quits. Also there isn't any sass template examples. It will print out the media query block twice and leave the pixel ratio number empty.

{% for ratio in ratios %}
@media screen and (-webkit-min-device-pixel-ratio: {{ ratio.ratio }}), screen and (min--moz-device-pixel-ratio: {{ ratio.ratio }}),screen and (-o-min-device-pixel-ratio: {{ ratio.fraction }}),screen and (min-device-pixel-ratio: {{ ratio.ratio }}){
{% for image in images %}.{{ image.label }}{{ image.pseudo }}{% if not image.last %}, {% endif %}
{% endfor %}{
background-image:url('../images/[email protected]');
-webkit-background-size: {{ width }}px {{ height }}px;
-moz-background-size: {{ width }}px {{ height }}px;
background-size: {{ width }}px {{ height }}px;
}
}
{% endfor %}

@jorgebastida
Copy link
Owner

Hello @joshspivey , I think this issue is related to this one #146 (comment)

It looks like the documentation is not clear enough about how --css-template works.

glue (internally) provides a "good-enough" template for each of the output formats. These --X-template options were only added in order to allow people to hyper-customize glue's output in certain situations.

I might be wrong... but if you remove your --css-template option, everything should be ok.

Let me know if this fix your bug.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant