Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set cover art from MusicBrainz to the mp3 music file #53

Closed
josdem opened this issue Jan 4, 2025 · 1 comment
Closed

Set cover art from MusicBrainz to the mp3 music file #53

josdem opened this issue Jan 4, 2025 · 1 comment
Assignees
@josdem
Labels
0 - Backlog 1 - Ready 2 - Working <= 5 3 - Review development enhancement good first issue help wanted
Milestone
release 1.3.0

Comments

@josdem
Copy link
Owner

josdem commented Jan 4, 2025 •
edited
Loading

As user, I want to set cover art from MusicBrainz if the file is missing cover art so that I can complete missing metadata

Acceptance Criteria

  • I can see a cover art added to the file from MusicBrainz if it is missing
  • All tests are passing

References
@josdem josdem added this to the release 1.3.0 milestone Jan 4, 2025
@josdem josdem self-assigned this Jan 17, 2025
josdem added a commit that referenced this issue Jan 17, 2025
@josdem
#53 Refactoring method name
0631c71
josdem added a commit that referenced this issue Jan 17, 2025
@josdem
#53 Adding getting cover art implementation
f507abe
josdem added a commit that referenced this issue Jan 17, 2025
@josdem
#53 Passing negative scenario
059aaf3
josdem added a commit that referenced this issue Jan 17, 2025
@josdem
#53 Adding happy path
1578837
josdem added a commit that referenced this issue Jan 17, 2025
@josdem
#53 Avoiding duplicated code
2ca49b6
josdem added a commit that referenced this issue Jan 17, 2025
@josdem
#53 Avoiding cover art already exist scenario
e42a163
josdem added a commit that referenced this issue Jan 17, 2025
@josdem
#53 Updating version
d165bc6
josdem added a commit that referenced this issue Jan 17, 2025
@josdem
#53 Adding log message
5bd0d33
josdem added a commit that referenced this issue Jan 17, 2025
@josdem
#53 Resizing image and update table with new image
bcbe4e1
@josdem
Copy link
Owner Author

josdem commented Jan 17, 2025

PR merged: #70

@josdem josdem closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josdem josdem

Labels
0 - Backlog 1 - Ready 2 - Working <= 5 3 - Review development enhancement good first issue help wanted
Projects
None yet
Milestone
release 1.3.0
Development

No branches or pull requests
1 participant
@josdem