Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate complete metadata logic in a service #75

Open
josdem opened this issue Jan 25, 2025 · 0 comments
Open

Encapsulate complete metadata logic in a service #75

josdem opened this issue Jan 25, 2025 · 0 comments
Labels
0 - Backlog 1 - Ready development enhancement good first issue help wanted
Milestone
Unplanned release

Comments

@josdem
Copy link
Owner

josdem commented Jan 25, 2025 •
edited
Loading

As developer I want to encapsulate complete metadata logic in a service so that I can implement same steps using both LastFM and MusicBrainz services.

Acceptance Criteria

  • I have a single interface named: CompleteService
  • That service define three methods
    • boolean canComplete(Metadata metadata);
    • AlbumInfo getInfo(Metadata metadata)
    • ActionResult isSomethingNew(AlbumInfo albumInfo, Metadata metadata);
  • MusicBrainz and LastFM implements that interface
  • I can see all MusicBrainz complete logic out of CompleteController
  • All tests passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog 1 - Ready development enhancement good first issue help wanted
Projects
None yet
Milestone
Unplanned release
Development

No branches or pull requests
1 participant
@josdem