Is it normal to have multiple null-ls clients?

[FotiadisM]

hello and thank you for your contribution to the community.

The plugin seems to work as expected, only thing is that it creates a null-ls client for each buffer I enter and does not reuse the same one.

Is this considered normal behavior?

[jose-elias-alvarez]

Definitely not normal. Can you post your setup?

[FotiadisM]

Here is my setup .

I have two files, lua/lsp/null-ls.lua that just containts the setup of null-ls, and lua/lsp/lspconfig.lua that does all the ["server"].setup() stuff, inluding require("lspconfig")["null-ls"].setup().

[jose-elias-alvarez]

Hmm, I don't see any obvious problems in your config. Can you try moving require("lspconfig")["null-ls"].setup() to the null-ls setup file to rule out issues with nvim-lsp-installer? Also, where do you see the extra clients that are being created?

[FotiadisM]

Then I move require("lspconfig")["null-ls"].setup() to the the null-ls setup file I get the error packer.nvim: Error running config for null-ls.nvim: ...ck/packer/start/nvim-lspconfig/lua/lspconfig/configs.lua:35: attempt to index local 'config' (a nil value)

I also tried using after to load null-ls after the nvim-lspconfig setup but the same exact error.

The extra clients are created everywhere when I enter nvim on the netrw screen, and for every file I enter afterwords.

[FotiadisM]

Sorry the error was caused because I was's passing any arguments for the setup() function

local null_ls = require("null-ls")

local sources = {
	null_ls.builtins.formatting.prettier,
	null_ls.builtins.formatting.gofumpt,

	null_ls.builtins.code_actions.gitsigns
}

null_ls.config({ sources = sources })
require("lspconfig")["null-ls"].setup({
	capabilities =  vim.lsp.protocol.make_client_capabilities()
})

Now there is no error, but still, it creates a client for each buffer I enter

[jose-elias-alvarez]

Where are you seeing the additional clients? With your setup, no matter how many buffers I open I only see one null-ls client in :LspInfo, and :lua print(#vim.lsp.get_active_clients()) also prints 1.

[FotiadisM]

Yes I see the extra clients on using :LspInfo and :lua print(#vim.lsp.get_active_clients()).

I just upgraded to neovim nightly from neovim 0.5.1 and the problem persisted. weird

[jose-elias-alvarez]

Very strange. I can't reproduce this with your config on nightly or 0.5.1. The null-ls client doesn't actually do much, so I think this shouldn't have any negative effects, but feel free to open an issue if you're able to put together a minimal reproduction.

[FotiadisM]

I removed the plugin, reopen nvim and it seems the problem is else where because I have 3 different sumneko_lua lsp clients. But it doesn't open a new one for every file I enter, which is very strange, when I use Telescope to open a file, it will always create a new client, but when I open files through NvimTree, it sometimes creates a new client.

Anyway since it's not null-ls problem I wont' bother your any more, thank you very much for your help and all the great work with the plugin.