Peerdep on ember-source too strict? #82
Comments
abeforgit
added a commit
to lblod/ember-rdfa-editor
that referenced
this issue
Aug 24, 2023
7 tasks
|
Tests are run against Ember 3.16 and 3.20: ember-focus-trap/.github/workflows/ci.yml Lines 39 to 42 in 760b3bc The peer dependency was added in #80. The PR does not mention any reason for only allowing Ember >= 4.0 in peer dependency. So likely just a bug introduced by mistake. |
piemonkey
added a commit
to lblod/ember-rdfa-editor
that referenced
this issue
Apr 29, 2024
The previous fix to 1.0.1 was only done due to incorrect peerDeps of ember-focus-trap, which claim that ember-source `^4.0.0 || ^5.0.0` is needed. See josemarluedke/ember-focus-trap#82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #80 adds ember 4 as a minimum peerdep version, but according to the README, ember 3.16 and up is still supported?
Ran into this cause our 3.28 ember-try CI tests failed all of a sudden, with npm (node 18, also supported as per the readme) not able to resolve the peerdep.
If support was dropped, I'd also expect 1.1.0 to be a breaking release instead of a minor one.
The text was updated successfully, but these errors were encountered: