Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature embedded drawer #140

Open
knownasilya opened this issue Jan 30, 2021 · 6 comments
Open

Feature embedded drawer #140

knownasilya opened this issue Jan 30, 2021 · 6 comments
Labels
Type: Bug Something isn't working

Comments

@knownasilya
Copy link
Contributor

Where it takes over the parent element instead of the full page

@josemarluedke
Copy link
Owner

josemarluedke commented Jan 30, 2021

This is already supported when using renderInPlace argument. https://frontile.dev/docs/overlays/drawer#api

@knownasilya
Copy link
Contributor Author

Get this when I use that mode
frontile-drawer

@josemarluedke
Copy link
Owner

josemarluedke commented Jan 30, 2021

Ahh yeah, you need to add position: relative (.relative in Tailwindcss) to the parent.

image

image

@knownasilya
Copy link
Contributor Author

knownasilya commented Jan 31, 2021

frontile-drawer-rel
Still get some weird UI issues.

<div class='flex flex-col relative'>
  <Drawer
    @renderInPlace={{true}}
    @isOpen={{this.isDrawerOpen}}
    @onClose={{set this.isDrawerOpen false}} as |d|
  >
    <d.Header
      class='flex justify-between items-center text-gray-700 text-lg p-4'
    >
      Post Settings

@josemarluedke
Copy link
Owner

Humm, this is interesting... Could it be because of the flex? I guess I need to have a reproduction to debug it.

@josemarluedke josemarluedke added the Type: Bug Something isn't working label Feb 26, 2021
@MichalBryxi
Copy link
Contributor

MichalBryxi commented Sep 3, 2022

I think I bumped on the same. The sidebar drawer renders completely off the screen - It's still present in the DOM, but is not visible. I can see it animating and then it disappears.

Edit: I think it is a diff between:

+   "@frontile/overlays": "^0.14.0",
-    "@frontile/overlays": "^0.13.1",

When I install back 0.13.1 the issue seems to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants