Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-element-helper required in alpha #297

Open
cloke opened this issue Jun 24, 2024 · 1 comment
Open

ember-element-helper required in alpha #297

cloke opened this issue Jun 24, 2024 · 1 comment

Comments

@cloke
Copy link
Contributor

cloke commented Jun 24, 2024

We just updated to v.17 alpha. It looks like there is a hard dependency on ember-element-helper because of the divider component. I was going to PR adding the dependency, but made me think, since there is only one component using this add-on would the direction be to add the package or modify divider component to use a different approach.

@josemarluedke
Copy link
Owner

Feel free to open a PR changing the approach, but one restriction I have is that it needs to work in FastBoot, so the modifier won't do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants