Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let usernames have funnier char than just alphanumeric #9

Open
josephernest opened this issue Nov 22, 2016 · 1 comment
Open

Let usernames have funnier char than just alphanumeric #9

josephernest opened this issue Nov 22, 2016 · 1 comment

Comments

@josephernest
Copy link
Owner

josephernest commented Nov 22, 2016

Because of many malicious utf8 characters such as this one:
http://unicode-table.com/fr/200D/

or even things like this in username: 
 (see http://code.cside.com/3rdpage/us/newLine.html)

I had to ban everything else than alphanumeric characters https://github.com/josephernest/talktalktalk/blob/master/talktalktalk.py#L49

username = re.sub(r'\W+', '', username)

Would be cool to allow more UTF8 characters (even ❤ ☀ ☆ ☂ ☻ ♞ ☯ ).

Which ones to allow, which ones to ban?

@dangayle
Copy link

Here's a great list: http://apps.timwhitlock.info/emoji/tables/unicode

These are basically the ones built into iOS, which you know have been scrutinized for safety and appropriateness. Some sort of regex whitelist might be available somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants