Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended package configuration of Serverless will be incompatible #29

Open
svestu opened this issue Apr 6, 2021 · 0 comments
Open

Comments

@svestu
Copy link

svestu commented Apr 6, 2021

Hello there,

according to a deprecation message of the current Serverless-CLI (2.33.1), the support of package.include and package.exclude will be replaced:

Deprecation warning: Support for "package.include" and "package.exclude" will be removed with next major release. Please use "package.patterns" instead

Changing the configuration like documented in https://www.serverless.com/framework/docs/providers/aws/guide/packaging/ this package throws an error:

TypeError: Cannot read property 'push' of undefined at PackageRubyBundlePlugin.beforePackage ([...]node_modules\serverless-ruby-package\index.js:85:45) at PluginManager.invoke ([...]node_modules\serverless\lib\classes\PluginManager.js:551:20)

I already took a look at the index.js. It seems that the usage of exclude and include needs to be redone. I have no idea how to do this without breaking backward compatibility.

svestu added a commit to svestu/serverless-ruby-package that referenced this issue Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant