Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter02 Golang CacheRequest bug #106

Open
gopherhiro opened this issue Nov 20, 2023 · 0 comments
Open

Chapter02 Golang CacheRequest bug #106

gopherhiro opened this issue Nov 20, 2023 · 0 comments

Comments

@gopherhiro
Copy link

gopherhiro commented Nov 20, 2023

Here it should not be possible to cache and then call the callback function directly, so the correct way to write it would be:

if !r.CanCache(request)

func (r *Client) CacheRequest(request string, callback func(string) string) string {
	if !r.CanCache(request) {
		return callback(request)
	}

	pageKey := "cache:" + hashRequest(request)
	content := r.Conn.Get(pageKey).Val()

	if content == "" {
		content = callback(request)
		r.Conn.Set(pageKey, content, 300*time.Second)
	}
	return content
}
@gopherhiro gopherhiro changed the title Chapter01 Golang CacheRequest bug Chapter02 Golang CacheRequest bug Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant