Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

method "updateStats" of Chapter05.java has error logic #67

Open
lomoye opened this issue Jan 31, 2020 · 2 comments
Open

method "updateStats" of Chapter05.java has error logic #67

lomoye opened this issue Jan 31, 2020 · 2 comments
Assignees
@josiahcarlson
Labels
question

Comments

@lomoye
Copy link

lomoye commented Jan 31, 2020

the code of java Chapter05.java, method updateStats;
if the key "startKey" is null , has not set it to redis;
I see python has this logic, but java not.
@josiahcarlson josiahcarlson self-assigned this Jan 31, 2020
@josiahcarlson
Copy link
Owner

Thank you for the bug report. I will check and fix this soon.

@josiahcarlson
Copy link
Owner

Finally had the chance. Isn't this the default handling?
https://github.com/josiahcarlson/redis-in-action/blob/master/java/src/main/java/Chapter05.java#L321

Was there some other missing default?

@josiahcarlson josiahcarlson added question and removed bug labels Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josiahcarlson josiahcarlson

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josiahcarlson @lomoye