Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safari > 11 QuotaExceededError error in private mode #18

Open
boynet opened this issue Mar 15, 2018 · 2 comments
Open

safari > 11 QuotaExceededError error in private mode #18

boynet opened this issue Mar 15, 2018 · 2 comments

Comments

@boynet
Copy link

boynet commented Mar 15, 2018

the error is raised when using localStorage in safari private mode in version prior to 11, the solution is pretty easy
wrap localStorage call in setUserOptions() with try catch:

you can read more about it here https://stackoverflow.com/questions/21159301/quotaexceedederror-dom-exception-22-an-attempt-was-made-to-add-something-to-st

@jossef
Copy link
Owner

jossef commented Mar 22, 2018

Thanks for the report!

would you please make a Pull Request with a fix?

@boynet
Copy link
Author

boynet commented May 3, 2018

I can but I made another change in my fork let me know what you think:
the problem is in applyTextZoom() this function run even if the user never changes any accessibility option, and it really messed up the performance on site its not a good idea to mess with the dom when not needed, I made a quick hack but I can make a pretty fix it, to only run if zoom is changed or is not 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants