Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fullscreen but disable hotkeys #352

Open
noetix opened this issue Feb 26, 2020 · 1 comment
Open

Allow fullscreen but disable hotkeys #352

noetix opened this issue Feb 26, 2020 · 1 comment

Comments

@noetix
Copy link

noetix commented Feb 26, 2020

I've built a custom view that includes a form, however when typing f in the input box fullscreen mode enables.

Would it be possible to either:

  • allow configuration to disable hotkeys but still allow fullscreen mode via the button; or
  • ideally, check the event target node type to ignore form inputs

Happy to work on a PR but would like a direction before starting.

@vgmcglaughlin
Copy link

I ran into this as well. As a workaround, I added an event.preventDefault() in my input change handler, which prevented the F from triggering fullscreen mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants