Option to Disable Automatic Webbrowser Opening #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @uberfastman , |
|
Thanks so much @josuebrunel! |
|
@josuebrunel thanks so much for accepting my PR! I would be grateful as well if you could let me know when the PyPi package has been updated so I can pull the latest version that includes these updates! |
|
@uberfastman it's on pypi now. Let me know if it works as expected |
|
@josuebrunel works perfectly, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the OAuth process in the
yahoo-oauthlibrary always opens a web browser when a new token is requested. However, if running OAuth inside a container (Docker), it is extremely difficult (if not impossible in some environments) for the Docker container to talk to the host machine.As such, this small PR adds the ability to include a keyword/named argument,
browser_callback, which, when set toFalse, will simply include the authorization URL in the verification code input request, allowing users to click on the link themselves to get the Yahoo OAuth verification code.