Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: add a check to look for SQLite database only #198

Open
r0ny123 opened this issue Jul 31, 2020 · 8 comments
Open

Improvement: add a check to look for SQLite database only #198

r0ny123 opened this issue Jul 31, 2020 · 8 comments
Assignees

Comments

@r0ny123
Copy link

r0ny123 commented Jul 31, 2020

Currently, at the time of diffing while selecting the SQLite database to diff against, it looks for .idb, .i64, etc. rather than checking for sqlite database, every time we have to change it to All files (*) through file explorer to import the .sqlite to diff against other. I found this kinda lil annoying, so we can add a check to only look for .sqlite file on that current directory.

@joxeankoret
Copy link
Owner

The problem is that I don't really know how to change it, as Form.FileInput doesn't have any property to set the file extensions and the field value seems to be ignored in my tests. If anybody knows how to fix it, I can do it right away. However, personally, I have no idea how to do so.

@HongThatCong
Copy link

I have fix this in my port

@joxeankoret
Copy link
Owner

I have tried your fix adding , hlp="SQLite database (*.sqlite)". I can't see it working in neither IDA 7.5 for Windows nor for Linux.

@HongThatCong
Copy link

HongThatCong commented Feb 7, 2021

You can try with this code.
In my port, file diaphora_ida.py:
Line 515:

    def set_options(self, opts):
        if opts.file_out is not None:
            self.iFileSave.value = opts.file_out
            if not self.iFileSave.value:
                self.iFileSave.value = "*.sqlite"
        if opts.file_in is not None:
            self.iFileOpen.value = opts.file_in
            if not self.iFileOpen.value:
                self.iFileOpen.value = "*.sqlite"

Line 2428:

    elif opts.file_in != "*.sqlite":
        bd.diff(opts.file_in)                

joxeankoret added a commit that referenced this issue Feb 8, 2021
GUI: Filter *.sqlite databases in the file dialog.
@r0ny123
Copy link
Author

r0ny123 commented Dec 25, 2021

Hello @joxeankoret, this is not fixed.

@r0ny123
Copy link
Author

r0ny123 commented Apr 10, 2023

Pinging again @joxeankoret. This is not fixed yet.

@joxeankoret joxeankoret self-assigned this Apr 10, 2023
@joxeankoret joxeankoret added this to the Diaphora 3.0 milestone Apr 10, 2023
@joxeankoret joxeankoret reopened this Apr 10, 2023
@joxeankoret joxeankoret modified the milestones: Diaphora 3.0, Diaphora 3.1 Sep 30, 2023
@r0ny123
Copy link
Author

r0ny123 commented Sep 30, 2023

The milestone should be Diaphora 3.2, no? Cause you already released 3.1 😅.

@joxeankoret
Copy link
Owner

🤦‍♀️ Of course it's 3.2.

@joxeankoret joxeankoret removed this from the Diaphora 3.2 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants