Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use time.monotonic() instead of time.time() #220

Closed
BlueAmulet opened this issue Jun 3, 2021 · 3 comments
Closed

Use time.monotonic() instead of time.time() #220

BlueAmulet opened this issue Jun 3, 2021 · 3 comments

Comments

@BlueAmulet
Copy link

BlueAmulet commented Jun 3, 2021

Whenever the system time changes, as a result of DST or VM resuming, the result of time.time() can wildly change throwing off any ETA estimate, elapsed time measure, or timeouts.

time.monotonic() has the same resolution and tick rate as time.time() does, except that it's not affected by system time changes, and has been around since python 3.3 for compatibility concern.

joxeankoret added a commit that referenced this issue Aug 1, 2021
BUG: Do not crash when we cannot analyse one Diaphora SQLite database.
BUG: Diaphora was incorrectly searching the pattern '{}' instead of '[]' for empty list field values. Fix for #219.
GUI: When a reverser uses the "Diff pseudo-code" option and both codes are equal, show a warning message, but also show the diffing.
HEUR: In heuristic "Call Address Sequence" use also the "Partial results" when the function name is the same.
HEUR: Added heuristic "Same RVA". Only matches with a minimum ratio of 0.7 will be considered.
HEUR: Removed the "Slow" flag from the heuristic "Same Rare Constant".
HEUR: Use the 3 calculated fuzzy hashes in heuristic "Pseudo-code Fuzzy Hash".
HEUR: Moved heuristic "Similar Pseudo-code and Names" from the probably unreliable category to normal.
HEUR: Removed wrong heuristics "Similar Small Pseudo-codes" and "Equal Small Pseudo-codes" because they caused a lot of false positives (heuristics for finding matches tend to fail with small functions, and these were no exception).

Also, applied suggestion for issue #220.
@joxeankoret
Copy link
Owner

Done!

@fr0gger

This comment was marked as resolved.

@BlueAmulet
Copy link
Author

IDA before 7.4 uses Python 2
See #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants