Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Command invalid command calls not handled appropriately #4

Open
joytqt-1202 opened this issue Mar 31, 2023 · 0 comments
Open

Open Command invalid command calls not handled appropriately #4

joytqt-1202 opened this issue Mar 31, 2023 · 0 comments

Comments

@joytqt-1202
Copy link
Owner

Description

open command to open a social media platform of an existing contact does not work as expected.
This is an interesting and useful feature to implement but it has some flaws.

According to the user guide and the command result box, there is nothing that tells the user that open PERSON_INDEX is an invalid command format, and that at least one of the parameters tg/, wa/ or ig/ has to be specified. In fact, open PERSON_INDEX seems like a valid command from the way that it was documented, however, the results are of no use to the user.

Steps to Reproduce

Case 1: no social media
  1. add n/unique person name
  2. search n/unique person name
  3. open 1
Case 2: only 1 social media

Using the sample data provided

  1. open 5
Case 3: multiple social medias

Using the sample data provided

  1. open 1

Expected Output

Case 1: no social media / Case 3: multiple social medias

Command Result Box showing some form of an error message

Case 2: only 1 social media

Open the only social media available

Actual Output

Notice the command box, but no external application was opened

image.png

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant