Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Improve Images #17

Open
SuperSandro2000 opened this issue Apr 23, 2020 · 1 comment
Open

Improve Images #17

SuperSandro2000 opened this issue Apr 23, 2020 · 1 comment

Comments

@SuperSandro2000
Copy link

Right now the images don't use any kind of templating I could find cause otherwise I would have done a PR to fix all those issues:

  • apt cache is not getting deleted and apt-get update does not run in the same layer as apt-get install which is against dockers best practices and can lead to caching issues where you never install never packages
  • chromedriver.zip does not get deleted and shipped in the final image which unnecessarily increases image size
  • The script just installs any latest version of Chrome and is not reproducible
  • download mirrors are hard coded
  • older alpine versions are used instead of the latest
  • you run apk update which is not necessary and apk add should be run with --no-cache
@dvasdekis
Copy link

What would it take to add templating so that you could do this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants