You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, thanks a lot for this custom component. I realized that custom_components/mcp23017/const.py defines a constant number for the bus being used /dev/i2c-#. In my case this is not sufficient and I would think it would be best to let this be configured.
Would you accept a PR that makes this a config?
The text was updated successfully, but these errors were encountered:
TKone7
changed the title
Customize bus
Customize bus number
Nov 26, 2024
Sure/happy to support, just make sure it is optional, support config flow (configuration.yaml not a must), defaults to current bus and doesn't break existing configflow/configuration.yaml configurations.
There are two options wrt bus number configuration:
it remains a global settings, i.e. just an option to change the current default (low hanging fruit)
it becomes a component property (better/more complex change but it should only affect the toplevel logic as MCP23017 class has been prepared to support that already)
Hey, thanks a lot for this custom component. I realized that
custom_components/mcp23017/const.py
defines a constant number for the bus being used/dev/i2c-#
. In my case this is not sufficient and I would think it would be best to let this be configured.Would you accept a PR that makes this a config?
The text was updated successfully, but these errors were encountered: