New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize protobuf copies #10

Open

jpittis opened this issue Dec 2, 2022 · 0 comments

Labels

perf

Owner

jpittis commented Dec 2, 2022

For ease of implementation I’ve used clone liberally (e.g. DiscoveryRequest, Node, etc.)

I suspect we could mostly save these copies via immutable references and possibly weak references.

I’m not sure how much the copies cost in the first place though… Node can be an awfully large payload. Probably worth generating a flame graph.

jpittis added the perf label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment