Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong sorting of years in Game Service #16

Open
pakal opened this issue Apr 17, 2017 · 0 comments
Open

Wrong sorting of years in Game Service #16

pakal opened this issue Apr 17, 2017 · 0 comments

Comments

@pakal
Copy link

pakal commented Apr 17, 2017

This line :

return _(this.steps).map('year').compact().uniq().sort().value();

has a problem : when having 11 years, year 10 and year 11 are sorted before year 2 ; it must confuse strings and numbers.

We use lodash's sortBy() instead,it seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant