Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AdaBoostClassifier (revisited) #377

Open
MooTong123 opened this issue Apr 21, 2023 · 1 comment
Open

Support for AdaBoostClassifier (revisited) #377

MooTong123 opened this issue Apr 21, 2023 · 1 comment

Comments

@MooTong123
Copy link

I am going to generate pmml file for adaboost model, but it failed. I found a similar problem in 2017. (jpmml/jpmml-sklearn#41) Does the latest version of sklearn2pmml support adaboost now?

@vruusmann
Copy link
Member

Does the latest version of sklearn2pmml support adaboost now?

The list of supported SkLearn transformer and model types is given in JPMML-SkLearn's README file: https://github.com/jpmml/jpmml-sklearn#supported-packages

The sklearn.ensemble.AdaBoostRegressor class is listed, but the AdaBoostClassifier class isn't.

I found a similar problem in 2017 (jpmml/jpmml-sklearn#41)

I checked my comments there, and they appear to be relevant today as well.

In short, it should be possible to support AdaBoostClassifier.predict(X), but not AdaBoostClassifier.predict_proba(X).

Will your application scenario be satisfied with AdaBoostClassifier.predict(X) alone?

The first thing to do would be to create a small test script that verifies the earlier claim that predict(X) and predict_proba(X) methods make conflicting predictions. If it's still the case, then I'd say that this model type does not deserve any further attention. There are better (ie. "more logical") boosted classifiers available.

@vruusmann vruusmann changed the title Does it support adaboost model in latest version? Support for AdaBoostClassifier (revisited) Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants