Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sigma_t update in ValueAgent #18

Open
AgataCieslik opened this issue Jun 10, 2023 · 0 comments
Open

Incorrect sigma_t update in ValueAgent #18

AgataCieslik opened this issue Jun 10, 2023 · 0 comments

Comments

@AgataCieslik
Copy link

In ValueAgent.updateEstimates():

self.sigma_t = (self.sigma_n * self.sigma_t) / (self.sigma_n + self.sigma_t)

This line provides incorrect sigma_t estimate, should be:

self.sigma_t = (self.sigma_n * sigma_tprime) / (self.sigma_n + sigma_tprime)

or, equivalentely:

self.sigma_t  = sigma_tprime
self.sigma_t = (self.sigma_n * self.sigma_t) / (self.sigma_n + self.sigma_t) 

This leads to incorrect r_t, sigma_t and r_T estimates (since start value for sigma_t is always 0, sigma_t is always 0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant