Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA updates #4398

Merged
merged 2 commits into from
Nov 13, 2024
Merged

QA updates #4398

merged 2 commits into from
Nov 13, 2024

Conversation

Fercas123
Copy link
Contributor

@Fercas123 Fercas123 commented Nov 12, 2024 •
edited
Loading

add no injection qas for dialog, dropzone and overlay qa stories

closes #3713

@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 0:16am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5a2d06c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Fercas123 Fercas123 added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 12, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 12, 2024
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 13, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 13, 2024
@origami-z
Copy link
Contributor

Overlay focus style is not great in QA

@origami-z origami-z merged commit 2301012 into main Nov 13, 2024
14 of 15 checks passed
@origami-z origami-z deleted the add-no-injection-qas branch November 13, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding approved these changes

@origami-z origami-z origami-z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component QA Story fix up
3 participants
@Fercas123 @origami-z @joshwooding