Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image URLs showing as undefined #19

Open
taylorbrooks opened this issue Feb 19, 2019 · 6 comments
Open

Image URLs showing as undefined #19

taylorbrooks opened this issue Feb 19, 2019 · 6 comments

Comments

@taylorbrooks
Copy link

After uploading images to the source bucket, I can see that it successfully generates resized images and rebuilds the site.

However, the images won't display... On the main page, all of the image src attributes show undefined where the filename would typically be. And on an individual picture page, the image looks like it is missing altogether.

Any ideas?

screen shot 2019-02-19 at 9 36 24 am

screen shot 2019-02-19 at 9 36 42 am

@taylorbrooks
Copy link
Author

I think I found out the issue. I think everything should be in a folder in the bucket. I just uploaded images to the bucket.

I'm curious how many levels of folders this can have and how awspics will handle it.

@taylorbrooks
Copy link
Author

Also, if I remove images from the source bucket, will something be smart enough to recognize that and clean up the site?

@jpsim
Copy link
Owner

jpsim commented Feb 19, 2019

My folder structure on my source website is

pics/
  original/
    Album Title 1/
      1.jpg
      2.jpg
      3.jpg
    Album Title 2/
      1.jpg
      2.jpg
      3.jpg
    Album Title 3/
      1.jpg
      2.jpg
      3.jpg

I'm curious how many levels of folders this can have and how awspics will handle it.

If I recall correctly, this is the only structure supported by the site as-is.

Also, if I remove images from the source bucket, will something be smart enough to recognize that and clean up the site?

Again if I recall correctly, no there's no clean up in place.

@taylorbrooks
Copy link
Author

Should there be a clean up in place? I'm happy to build the lambda funcs.

@jpsim
Copy link
Owner

jpsim commented Feb 26, 2019

It'd be great to have cleanup funcs, if you want to contribute them! Thanks for suggesting :)

@jsloan117
Copy link
Contributor

jsloan117 commented Mar 31, 2019

From my own testing, with making this publically accessible. The folder structure for the origin bucket must be as below, else the original copies link doesn't work either. I've also noticed it seems the site-builder creates false links to a "pics" album, which doesn't exist. I can only assume it's being pulled from the below structure and not being sanitized correctly? Sadly I don't know JS :-/

pics/
  original/
    Album Title 1/
      1.jpg
      2.jpg
      3.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants