Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_credentials not constant time string compare #21

Open
MRoci opened this issue May 31, 2019 · 0 comments · May be fixed by #22
Open

check_credentials not constant time string compare #21

MRoci opened this issue May 31, 2019 · 0 comments · May be fixed by #22

Comments

@MRoci
Copy link

MRoci commented May 31, 2019

check_credentials does not use a constant time string comparison method.
This behaviour is unsafe and i think it could lead in a potential timing attack
@MRoci MRoci linked a pull request May 31, 2019 that will close this issue
Open
@ashokdelphia ashokdelphia mentioned this issue Jul 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check credentials constant time comparison MRoci/flask-basicauth
1 participant
@MRoci