Implement ESCDELAY environment value #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 95.38% 95.42% +0.04%
==========================================
Files 9 9
Lines 1018 1027 +9
Branches 215 216 +1
==========================================
+ Hits 971 980 +9
Misses 43 43
Partials 4 4 ☔ View full report in Codecov by Sentry. |
this should help with dubious test coverage results, i wasn't using pytest fixture right anyway
avylove
reviewed
Dec 5, 2023
D301: Use r""" if any backslashes in a docstring
Use r"""raw triple double quotes""" if you use any backslashes
(\) in your docstrings.
Exceptions are backslashes for line-continuation and unicode escape
sequences \N... and \u... These are considered intended unescaped
content in docstrings.
- fix for 'pylint: disable' - pin docformatter, As it seems the bug that @avylove created may not been addressed, freeze docformatter for now, to prevent failing CI PyCQA/docformatter#264
|
Thanks @avylove I also went ahead and pinned docformatter, as I'm not sure PyCQA/docformatter#264 will be addressed anytime soon, should allow our other builds to succeed. |
|
too bad really, I was enjoying being exactly 666 commits ahead of blessings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #158
Also pins docformatter due to related issue PyCQA/docformatter#264