Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

queue is not FIFO, but LIFO actually.. #102

Open
aki-s opened this issue Apr 7, 2021 · 1 comment
Open

queue is not FIFO, but LIFO actually.. #102

aki-s opened this issue Apr 7, 2021 · 1 comment

Comments

@aki-s
Copy link

aki-s commented Apr 7, 2021 •
edited
Loading

Version of go-workers

v0.0.0-20180112190529-dbf81d0b75bb

Details

  • line.86 in workers.fetcher.go
  • line.81 in workers.enqueue.go

image

My concern

I don't know the spec of Sidekiq, but I suspect we should use lpush instead of rpush to be FIFO.
What do you think Mr. @jrallison ?

It looks Sidekiq is actually FIFO sidekiq/sidekiq#3420 .
@aki-s
Copy link
Author

aki-s commented Apr 8, 2021

I heard from my co-worker that
fork project of this one has fixed the issue I've mentioned at
digitalocean/go-workers2#5 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aki-s