Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit hook preventing commit leads to Vimagit wanting to amend the last commit #159

Open
erAck opened this issue Feb 16, 2018 · 3 comments
Labels

Comments

@erAck
Copy link

erAck commented Feb 16, 2018

Having a pre-commit hook that vetoes the current commit (for example because of trailing blanks or other checks), Vimagit on pressing CC acts as if CA was pressed and wants to amend the last commit instead of creating a new one. Equally bad, it does not display the output of the commit hook.

@jreybert
Copy link
Owner

OK, I get your setup.

Anyway, could you provide your pre commit hook and a faulty commit please?

@jreybert jreybert added the bug label Feb 16, 2018
@erAck
Copy link
Author

erAck commented Feb 16, 2018

Hook in question is https://cgit.freedesktop.org/libreoffice/core/tree/.git-hooks/pre-commit
Faulty commit would be any source file with a trailing blank on a line.

@jreybert
Copy link
Owner

OK thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants