Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 2.1.5 and latest support. #288

Merged
merged 4 commits into from
May 25, 2019
Merged

Conversation

DaniilSezonov
Copy link
Contributor

Close issue #286.

@gtnx
Copy link
Collaborator

gtnx commented May 21, 2019

Looks good.
@jrief I see that last merged PR was almost one year ago. Have you considered integrating other maintainers?

@jrief
Copy link
Owner

jrief commented May 21, 2019

Have you considered integrating other maintainers?

Yes, but noone asked until now. Would you like to become one?

@gtnx
Copy link
Collaborator

gtnx commented May 21, 2019

Yes.
I use this package in production in my company for almost 4 years now. I'm not super familiar with this package codebase but i can totally support you on those kind of tickets which are important for the community.

@gtnx
Copy link
Collaborator

gtnx commented May 21, 2019

@DaniilSezonov Could you add the 2.1.5 to the ci matrix. IT's in travis.yml in the env section?
Thanks

@jrief
Copy link
Owner

jrief commented May 21, 2019

btw., what's your username on PyPI?

@DaniilSezonov
Copy link
Contributor Author

Something was wrong, sorry, I have no experience with CI/CD configuration.

@DaniilSezonov
Copy link
Contributor Author

Trying again

@gtnx
Copy link
Collaborator

gtnx commented May 21, 2019

@jrief this is guillaume.thomas

@gtnx
Copy link
Collaborator

gtnx commented May 25, 2019

As i said it looks good. I tested it using a personal project and not the example project which still needs to be compatible with latest django versions (See #246).

@gtnx gtnx merged commit db44608 into jrief:master May 25, 2019
@gtnx
Copy link
Collaborator

gtnx commented May 25, 2019

@jrief Could you add me as well on pypi? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants