Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer works #381

Open
raboof opened this issue Jan 28, 2025 · 7 comments · Fixed by #382
Open

No longer works #381

raboof opened this issue Jan 28, 2025 · 7 comments · Fixed by #382
Assignees

Comments

@raboof
Copy link
Contributor

raboof commented Jan 28, 2025

The action installs scalafmt with https://raw.githubusercontent.com/scalameta/scalafmt/master/bin/install-scalafmt-native.sh but that doesn't exist anymore since scalameta/scalafmt#4738 🤔

@pjfanning
Copy link
Contributor

I raised scalameta/scalafmt#4759

@pjfanning
Copy link
Contributor

One possible short term workaround is to use this versioned URL.

https://github.com/scalameta/scalafmt/blob/v3.8.6/bin/install-scalafmt-native.sh

@kitbellew
Copy link

@tgodzik is adding it back, temporarily, and it will be removed again, permanently, shortly after we have been satisfied that scala-native works. this action needs to be modified in the meantime if you want to continue using it.

@jrouly
Copy link
Owner

jrouly commented Jan 28, 2025

Yikes.

@jrouly
Copy link
Owner

jrouly commented Jan 28, 2025

I might begin recommending users migrate to the scala-cli-setup-action since that appears to be what Scalameta is recommending in their installation docs, and it doesn't seem like a huge lift to get there from here.

But in the meantime I'll look into replacing the install-scalafmt-native.sh script usage in this action.

@jrouly jrouly self-assigned this Jan 28, 2025
@jrouly
Copy link
Owner

jrouly commented Jan 28, 2025

I've issued a re-release of v4 that should address the issue in the near term by pinning to the versioned installer you linked @pjfanning.

@jrouly jrouly linked a pull request Jan 28, 2025 that will close this issue
@pjfanning
Copy link
Contributor

Thanks @jrouly - I reran a failed job in Apache Pekko project and it passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants