Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications page & dropdown improvements #43

Open
4 tasks done
MartinKolarik opened this issue Oct 23, 2024 · 1 comment · May be fixed by #61
Open
4 tasks done

Notifications page & dropdown improvements #43

MartinKolarik opened this issue Oct 23, 2024 · 1 comment · May be fixed by #61

Comments

@MartinKolarik
Copy link
Member

MartinKolarik commented Oct 23, 2024

  • new page listing notifications, like https://github.com/notifications (design in Figma)
  • restrict the current dropdown to 5 notifications; add a link as the sixth item that leads to the page (see updated Figma)
  • animate current dropdown expand/collapse
  • improve read/unread indication in the dropdown (see updated Figma)
@MartinKolarik MartinKolarik changed the title Notifications page & dropdown limit Notifications page & dropdown improvements Oct 23, 2024
@MartinKolarik
Copy link
Member Author

@xbpcb for the newly added timestamps, please use this format (add to utils):

export const formatDateTime = (dateTime: string | Date | null) => {
	if (!dateTime) {
		return '';
	}

	if (typeof dateTime === 'string') {
		dateTime = new Date(dateTime);
	}

	return dateTime.toLocaleDateString('en-US', { day: 'numeric', month: 'short', year: 'numeric', hour: 'numeric', minute: 'numeric' });
};

@xbpcb xbpcb linked a pull request Feb 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants