Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New note is not added to the list #3

Open
rtokun opened this issue Nov 28, 2019 · 0 comments
Open

New note is not added to the list #3

rtokun opened this issue Nov 28, 2019 · 0 comments

Comments

@rtokun
Copy link

rtokun commented Nov 28, 2019

In the branch with custom ItemKeyedDataSource and Koin, when we add new Note it is not being added to the list, until we kill the app and launch it again.
I think it happens because of DataSource is not invalidated, while it should be.
Also, I think it wrong to inject DataSource as singleton, because each time NotesDataSourceFactory.create() has to return new DataSource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant