Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies of playbar in CMakeList.txt#find_package #42

Open
tillschaefer opened this issue Jan 19, 2018 · 0 comments
Open

Dependencies of playbar in CMakeList.txt#find_package #42

tillschaefer opened this issue Jan 19, 2018 · 0 comments

Comments

@tillschaefer
Copy link

There are some dependencies missing in CMakeList.txt and/or in README:md (that are currently only fulfilled in a transient way):

  • qtgui (both)
  • qtcore (readme)
  • qtwidgets (readme)
  • qtquickcontrols (readme)
  • frameworks KConfig (both)
  • frameworks KCoreAddons (both)
  • frameworks KI18n (readme)
  • frameworks KWidgetsAddons (both)

The dependency on the follwing packages is not necessary:

  • plasma-workspace (readme)

Furthermore the qml dependencies are only runtime dependencies (all the QML stuff, qtdeclarative), its nice to add them in cmake with the help of kde/extra-cmake-modules via:
ECMQMLModules#ecm_find_qmlmodule
You can find an example here: https://phabricator.kde.org/D7273

However, they are only present in frameworks >=5.28. Thus, you would need to require a recent frameworks version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant