Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft support in Readme #195

Closed
gregsdennis opened this issue Sep 19, 2017 · 11 comments
Closed

Draft support in Readme #195

gregsdennis opened this issue Sep 19, 2017 · 11 comments

Comments

@gregsdennis
Copy link
Member

I think it may be beneficial to indicate which drafts are supported by the libraries listed in the readme file. For instance, Manatee.Json v8+ supports draft-06 (previously only draft-04 was supported).

@handrews
Copy link
Contributor

Hmm... the README is out of date in general, as it doesn't mention draft-06 at all :-/

I think we might want to move the list of implementations and tests out to the web site, which does track which project implements what. I notice Manatee.Json isn't even on the web site, which we should fix (I'll do that right now).

Also paging @adamvoss on the idea of tracking test coverage on the web site.

@handrews
Copy link
Contributor

@gregsdennis
Copy link
Member Author

You're my hero.

@handrews
Copy link
Contributor

@gregsdennis Now I just need a hero to review the PR :-P I've poked some people about it. After that I'll have the README here point to the software page.

Note that json-schema-org/website#125 already tracks the idea of adding test suite results on the software page. We should really do that :-/

@Julian
Copy link
Member

Julian commented Sep 25, 2017

Sorry, which PR is that :)?

(Also json-schema-org/json-schema-org.github.io#20 here tracks likely the same issue, and I believe I even threw a suggestion for how to do so on that ticket)

@gregsdennis
Copy link
Member Author

I like the idea of tracking the results!

@Julian
Copy link
Member

Julian commented Sep 25, 2017

No I'm lying and I didn't, but the idea was pretty simple, rather than just asking implementations to add themselves to the README, you ask for a PR that executes a build for each implementation (and then use the results of that to report on each implementation).

@gregsdennis
Copy link
Member Author

@Julian he mentions it a few comments up. It's on the schema.org site repo.

@handrews
Copy link
Contributor

@Julian json-schema-org/json-schema-org.github.io#154 is the PR (I copied stuff over to the web site so we're not maintaining it in two places, although if you prefer to also keep tracking it here I'm fine with that).

@Julian
Copy link
Member

Julian commented Sep 25, 2017 via email

@Julian
Copy link
Member

Julian commented Nov 29, 2019

Closing this in favor of json-schema-org/json-schema-org.github.io#314, which, if we ever do it, should handle this too.

@Julian Julian closed this as completed Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants