-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft support in Readme #195
Comments
Hmm... the README is out of date in general, as it doesn't mention draft-06 at all :-/ I think we might want to move the list of implementations and tests out to the web site, which does track which project implements what. I notice Manatee.Json isn't even on the web site, which we should fix (I'll do that right now). Also paging @adamvoss on the idea of tracking test coverage on the web site. |
You're my hero. |
@gregsdennis Now I just need a hero to review the PR :-P I've poked some people about it. After that I'll have the README here point to the software page. Note that json-schema-org/website#125 already tracks the idea of adding test suite results on the software page. We should really do that :-/ |
Sorry, which PR is that :)? (Also json-schema-org/json-schema-org.github.io#20 here tracks likely the same issue, and I believe I even threw a suggestion for how to do so on that ticket) |
I like the idea of tracking the results! |
No I'm lying and I didn't, but the idea was pretty simple, rather than just asking implementations to add themselves to the README, you ask for a PR that executes a build for each implementation (and then use the results of that to report on each implementation). |
@Julian he mentions it a few comments up. It's on the schema.org site repo. |
@Julian json-schema-org/json-schema-org.github.io#154 is the PR (I copied stuff over to the web site so we're not maintaining it in two places, although if you prefer to also keep tracking it here I'm fine with that). |
Ah cool. No, one place is certainly better than two, fine with that being
the one place.
…On Sep 25, 2017 5:46 PM, "Henry Andrews" ***@***.***> wrote:
@Julian <https://github.com/julian> json-schema-org/json-schema-
org.github.io#154
<json-schema-org/json-schema-org.github.io#154>
is the PR (I copied stuff over to the web site so we're not maintaining it
in two places, although if you prefer to also keep tracking it here I'm
fine with that).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#195 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUIXlK_5erTw8cq6if_JaegeJHlvF4Vks5smB8kgaJpZM4Pbx2p>
.
|
Closing this in favor of json-schema-org/json-schema-org.github.io#314, which, if we ever do it, should handle this too. |
I think it may be beneficial to indicate which drafts are supported by the libraries listed in the readme file. For instance, Manatee.Json v8+ supports draft-06 (previously only draft-04 was supported).
The text was updated successfully, but these errors were encountered: