Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idea: Use Playwright instead of Puppeteer for PDF generation #761

Open
Nezteb opened this issue Mar 22, 2023 · 2 comments
Open

Idea: Use Playwright instead of Puppeteer for PDF generation #761

Nezteb opened this issue Mar 22, 2023 · 2 comments

Comments

@Nezteb
Copy link
Contributor

Nezteb commented Mar 22, 2023

Currently resume-cli uses https://pptr.dev/api/puppeteer.page.pdf

Playwright also supports PDF generation, and it can be done directly from a CLI:
@vanhoutenbos
Copy link

Would be nice to have an option to chose which one to use, playwright seems more innovative at the moment but puppeteer just works

@levino
Copy link

levino commented Nov 14, 2023

Why not make a PR to show that it would work and the output would be nice too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@levino @Nezteb @vanhoutenbos