Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many registry-supported themes missing from themes page #84

Open
bencwallace opened this issue Jan 5, 2021 · 1 comment
Open

Many registry-supported themes missing from themes page #84

bencwallace opened this issue Jan 5, 2021 · 1 comment

Comments

@bencwallace
Copy link

Hi there. I'm a fan of this project but when I first saw it I was under the impression that there were very themes officially supported by the registry (just the 13 on the themes page). Then I realized the registry actually supports quite a few more themes than that, but the only way that I know to find out what they are is to read through the package.json. I think it would be beneficial to users (to help them find supported themes), theme creators (to promote their work), and this project (to show off all the available themes) to list more or all the themes on the themes page.

I'm not sure what the best way to go about this would be. Doing this by hand is a bit tedious, as you need to look up the author/website for each theme. Maybe a script could do this but it might be hacky. Maybe the best way would be to have a list of "more themes" without thumbnail/authors information underneath the current themes (which could be "feature" themes). Any thoughts?

@rbardini
Copy link

rbardini commented Jan 6, 2021

I like Storybook's approach:

Storybook addons are listed in the catalog and distributed via npm. The catalog is populated by querying npm's registry for Storybook-specific metadata in package.json.

Granted, it requires some automation work, but other than that it is pretty maintenance-free. We already enforce a naming convention for theme packages, so it may not require any changes from authors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants