From 93b0d9943ad030bfd111c1230b1e862b911e6343 Mon Sep 17 00:00:00 2001
From: vzhang03 <vzhang@vassar.edu>
Date: Mon, 22 Jul 2024 09:55:43 -0400
Subject: [PATCH] Pushing final changes addressing comments on the PR

---
 templates/extension-template-js/index.js     | 8 +++-----
 templates/extension-template-ts/src/index.ts | 4 ++--
 templates/plugin-template-js/index.js        | 8 +++-----
 templates/plugin-template-ts/src/index.ts    | 4 ++--
 4 files changed, 10 insertions(+), 14 deletions(-)

diff --git a/templates/extension-template-js/index.js b/templates/extension-template-js/index.js
index 85f13f35..fb7c44ac 100644
--- a/templates/extension-template-js/index.js
+++ b/templates/extension-template-js/index.js
@@ -1,5 +1,3 @@
-import { version } from "./package.json";
-
 var _globalName_ = (function (jspsych) {
   "use strict";
 
@@ -28,14 +26,14 @@ var _globalName_ = (function (jspsych) {
 
     on_finish(params) {
       return {
-        data1: 99, // Make sure this type and name matches data1
-        data2: "hello world!", // Make this this type and name matches data2
+        data1: 99, // Make sure this type and name matches the information for data1 in the data object contained within the info const.
+        data2: "hello world!", // Make sure this type and name matches the information for data2 in the data object contained within the info const.
       };
     }
   }
   ExtensionNameExtension.info = {
     name: "{name}",
-    version: version,
+    version: "1.0.0", // When working in a Javascript environment with no build, you will need to manually put set the version information. This is used for metadata purposes and publishing.
     data: {
       /** Provide a clear description of the data1 that could be used as documentation. We will eventually use these comments to automatically build documentation and produce metadata. */
       data1: {
diff --git a/templates/extension-template-ts/src/index.ts b/templates/extension-template-ts/src/index.ts
index 0e6e9cae..4abd5b00 100644
--- a/templates/extension-template-ts/src/index.ts
+++ b/templates/extension-template-ts/src/index.ts
@@ -48,8 +48,8 @@ class ExtensionNameExtension implements JsPsychExtension {
 
   on_finish = ({}: OnFinishParameters): { [key: string]: any } => {
     return {
-      data1: 99, // Make sure this type and name matches data1
-      data2: "hello world!", // Make this this type and name matches data2
+      data1: 99, // Make sure this type and name matches the information for data1 in the data object contained within the info const.
+      data2: "hello world!", // Make sure this type and name matches the information for data2 in the data object contained within the info const.
     };
   };
 }
diff --git a/templates/plugin-template-js/index.js b/templates/plugin-template-js/index.js
index 61fc9e29..7dde75fe 100644
--- a/templates/plugin-template-js/index.js
+++ b/templates/plugin-template-js/index.js
@@ -1,11 +1,9 @@
-import { version } from "./package.json";
-
 var _globalName_ = (function (jspsych) {
   "use strict";
 
   const info = {
     name: "{name}",
-    version: version,
+    version: "1.0.0", // When working in a Javascript environment with no build, you will need to manually put set the version information. This is used for metadata purposes and publishing.
     parameters: {
       /** Provide a clear description of the parameter_name that could be used as documentation. We will eventually use these comments to automatically build documentation and produce metadata. */
       parameter_name: {
@@ -45,8 +43,8 @@ var _globalName_ = (function (jspsych) {
     trial(display_element, trial) {
       // data saving
       var trial_data = {
-        data1: 99, // Make sure this type and name matches data1
-        data2: "hello world!", // Make this this type and name matches data2
+        data1: 99, // Make sure this type and name matches the information for data1 in the data object contained within the info const.
+        data2: "hello world!", // Make sure this type and name matches the information for data2 in the data object contained within the info const.
       };
       // end trial
       this.jsPsych.finishTrial(trial_data);
diff --git a/templates/plugin-template-ts/src/index.ts b/templates/plugin-template-ts/src/index.ts
index 9810f8a9..b2396d68 100644
--- a/templates/plugin-template-ts/src/index.ts
+++ b/templates/plugin-template-ts/src/index.ts
@@ -47,8 +47,8 @@ class PluginNamePlugin implements JsPsychPlugin<Info> {
   trial(display_element: HTMLElement, trial: TrialType<Info>) {
     // data saving
     var trial_data = {
-      data1: 99, // Make sure this type and name matches data1
-      data2: "hello world!", // Make this this type and name matches data2
+      data1: 99, // Make sure this type and name matches the information for data1 in the data object contained within the info const.
+      data2: "hello world!", // Make sure this type and name matches the information for data2 in the data object contained within the info const.
     };
 
     // end trial