From 760ca469d99f09435406ea471dea11fc4bc2aefb Mon Sep 17 00:00:00 2001
From: Maria <mariaemnylund@gmail.com>
Date: Mon, 11 Dec 2023 16:40:26 +0100
Subject: [PATCH 1/5] PLugin video several keyboard responses init

---
 .../.turbo/turbo-build.log                    |   0
 .../CHANGELOG.md                              |   3 +
 .../README.md                                 |  35 ++
 .../jest.config.cjs                           |   1 +
 .../package.json                              |  44 ++
 .../rollup.config.mjs                         |   3 +
 .../src/index.spec.ts                         |  77 ++++
 .../src/index.ts                              | 394 ++++++++++++++++++
 .../tsconfig.json                             |   7 +
 9 files changed, 564 insertions(+)
 create mode 100644 packages/plugin-video-several-keyboard-responses/.turbo/turbo-build.log
 create mode 100644 packages/plugin-video-several-keyboard-responses/CHANGELOG.md
 create mode 100644 packages/plugin-video-several-keyboard-responses/README.md
 create mode 100644 packages/plugin-video-several-keyboard-responses/jest.config.cjs
 create mode 100644 packages/plugin-video-several-keyboard-responses/package.json
 create mode 100644 packages/plugin-video-several-keyboard-responses/rollup.config.mjs
 create mode 100644 packages/plugin-video-several-keyboard-responses/src/index.spec.ts
 create mode 100644 packages/plugin-video-several-keyboard-responses/src/index.ts
 create mode 100644 packages/plugin-video-several-keyboard-responses/tsconfig.json

diff --git a/packages/plugin-video-several-keyboard-responses/.turbo/turbo-build.log b/packages/plugin-video-several-keyboard-responses/.turbo/turbo-build.log
new file mode 100644
index 00000000..e69de29b
diff --git a/packages/plugin-video-several-keyboard-responses/CHANGELOG.md b/packages/plugin-video-several-keyboard-responses/CHANGELOG.md
new file mode 100644
index 00000000..58856db7
--- /dev/null
+++ b/packages/plugin-video-several-keyboard-responses/CHANGELOG.md
@@ -0,0 +1,3 @@
+# @jspsych/plugin-video-several-keyboard-responses
+
+
diff --git a/packages/plugin-video-several-keyboard-responses/README.md b/packages/plugin-video-several-keyboard-responses/README.md
new file mode 100644
index 00000000..ef20c7cd
--- /dev/null
+++ b/packages/plugin-video-several-keyboard-responses/README.md
@@ -0,0 +1,35 @@
+# plugin-video-several-keyboard-responses
+
+## Overview
+
+This plugin plays a video and records responses generated by the keyboard, similar to [plugin-video-keyboard-response](https://www.jspsych.org/latest/plugins/video-keyboard-response). The stimulus can be displayed until the end or for a pre-determined amount of time. In addition to responses and response times, the video time is saved when a response is given using a keyboard.
+
+## Loading
+
+### In browser
+
+```js
+<script src="https://unpkg.com/@jspsych-contrib/plugin-video-several-keyboard-responses@1.0.0">
+```
+
+### Via NPM
+
+```
+npm install @jspsych-contrib/plugin-video-several-keyboard-responses
+```
+
+```js
+import jsPsychVideoSeveralKeyboardResponses from '@jspsych-contrib/plugin-video-several-keyboard-responses';
+```
+
+## Compatibility
+
+jsPsych v7.0. 
+
+## Documentation
+
+See [documentation](docs/jspsych-video-several-keyboard-responses.md)
+
+## Author / Citation
+
+This plugin was created by [marianylund](https://github.com/marianylund) with support from the [Department of Psychology](https://www.sv.uio.no/psi/english/index.html) at the University of Oslo.
diff --git a/packages/plugin-video-several-keyboard-responses/jest.config.cjs b/packages/plugin-video-several-keyboard-responses/jest.config.cjs
new file mode 100644
index 00000000..6ac19d5c
--- /dev/null
+++ b/packages/plugin-video-several-keyboard-responses/jest.config.cjs
@@ -0,0 +1 @@
+module.exports = require("@jspsych/config/jest").makePackageConfig(__dirname);
diff --git a/packages/plugin-video-several-keyboard-responses/package.json b/packages/plugin-video-several-keyboard-responses/package.json
new file mode 100644
index 00000000..cce0f1a9
--- /dev/null
+++ b/packages/plugin-video-several-keyboard-responses/package.json
@@ -0,0 +1,44 @@
+{
+  "name": "@jspsych/plugin-video-several-keyboard-responses",
+  "version": "0.1.0",
+  "description": "jsPsych plugin for playing a video file and getting several keyboard responses",
+  "type": "module",
+  "main": "dist/index.cjs",
+  "exports": {
+    "import": "./dist/index.js",
+    "require": "./dist/index.cjs"
+  },
+  "typings": "dist/index.d.ts",
+  "unpkg": "dist/index.browser.min.js",
+  "files": [
+    "src",
+    "dist"
+  ],
+  "source": "src/index.ts",
+  "scripts": {
+    "test": "jest --passWithNoTests",
+    "test:watch": "npm test -- --watch",
+    "tsc": "tsc",
+    "build": "rollup --config",
+    "build:watch": "npm run build -- --watch"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/jspsych/jspsych-contrib.git",
+    "directory": "packages/plugin-video-several-keyboard-responses"
+  },
+  "author": "Maria Emine Nylund",
+  "license": "MIT",
+  "bugs": {
+    "url": "https://github.com/jspsych/jspsych-contrib/issues"
+  },
+  "homepage": "https://github.com/jspsych/jspsych-contrib/tree/main/packages/plugin-video-several-keyboard-responses",
+  "peerDependencies": {
+    "jspsych": ">=7.1.0"
+  },
+  "devDependencies": {
+    "@jspsych/config": "^2.0.0",
+    "@jspsych/test-utils": "^1.1.2",
+    "jspsych": "^7.1.0"
+  }
+}
diff --git a/packages/plugin-video-several-keyboard-responses/rollup.config.mjs b/packages/plugin-video-several-keyboard-responses/rollup.config.mjs
new file mode 100644
index 00000000..299cdb6e
--- /dev/null
+++ b/packages/plugin-video-several-keyboard-responses/rollup.config.mjs
@@ -0,0 +1,3 @@
+import { makeRollupConfig } from "@jspsych/config/rollup";
+
+export default makeRollupConfig("jsPsychVideoSeveralKeyboardResponses");
diff --git a/packages/plugin-video-several-keyboard-responses/src/index.spec.ts b/packages/plugin-video-several-keyboard-responses/src/index.spec.ts
new file mode 100644
index 00000000..f12246fe
--- /dev/null
+++ b/packages/plugin-video-several-keyboard-responses/src/index.spec.ts
@@ -0,0 +1,77 @@
+import { pressKey, simulateTimeline, startTimeline } from "@jspsych/test-utils";
+import { initJsPsych } from "jspsych";
+
+import videoSeveralKeyboardResponses from ".";
+
+jest.useFakeTimers();
+
+beforeAll(() => {
+  window.HTMLMediaElement.prototype.pause = () => {};
+});
+
+// I can't figure out how to get this tested with jest
+describe("video-several-keyboard-responses", () => {
+  test("throws error when stimulus is not array #1537", async () => {
+    const jsPsych = initJsPsych();
+
+    const timeline = [
+      {
+        type: videoSeveralKeyboardResponses,
+        stimulus: "foo.mp4",
+      },
+    ];
+
+    await expect(async () => {
+      await jsPsych.run(timeline);
+    }).rejects.toThrowError();
+  });
+});
+
+describe("video-several-keyboard-responses simulation", () => {
+  test("data mode works", async () => {
+    const timeline = [
+      {
+        type: videoSeveralKeyboardResponses,
+        stimulus: ["foo.mp4"],
+      },
+    ];
+
+    const { expectFinished, getData } = await simulateTimeline(timeline);
+
+    await expectFinished();
+
+    expect(getData().values()[0].rt).toBeGreaterThan(0);
+    expect(typeof getData().values()[0].response).toBe("string");
+  });
+
+  // can't run this until we mock video elements.
+  test("visual mode works", async () => {
+    const jsPsych = initJsPsych();
+
+    const timeline = [
+      {
+        type: videoSeveralKeyboardResponses,
+        stimulus: ["foo.mp4"],
+        prompt: "foo",
+      },
+    ];
+
+    const { expectFinished, expectRunning, getHTML, getData } = await simulateTimeline(
+      timeline,
+      "visual",
+      {},
+      jsPsych
+    );
+
+    await expectRunning();
+
+    expect(getHTML()).toContain("foo");
+
+    jest.runAllTimers();
+
+    await expectFinished();
+
+    expect(getData().values()[0].rt).toBeGreaterThan(0);
+    expect(typeof getData().values()[0].response).toBe("string");
+  });
+});
diff --git a/packages/plugin-video-several-keyboard-responses/src/index.ts b/packages/plugin-video-several-keyboard-responses/src/index.ts
new file mode 100644
index 00000000..2deecbff
--- /dev/null
+++ b/packages/plugin-video-several-keyboard-responses/src/index.ts
@@ -0,0 +1,394 @@
+import { JsPsych, JsPsychPlugin, ParameterType, TrialType } from "jspsych";
+
+const info = <const>{
+  name: "video-several-keyboard-responses",
+  parameters: {
+    /** Array of the video file(s) to play. Video can be provided in multiple file formats for better cross-browser support. */
+    stimulus: {
+      type: ParameterType.VIDEO,
+      pretty_name: "Video",
+      default: undefined,
+      array: true,
+    },
+    /** Array containing the key(s) the subject is allowed to press to respond to the stimulus. */
+    choices: {
+      type: ParameterType.KEYS,
+      pretty_name: "Choices",
+      default: "ALL_KEYS",
+    },
+    /** Any content here will be displayed below the stimulus. */
+    prompt: {
+      type: ParameterType.HTML_STRING,
+      pretty_name: "Prompt",
+      default: null,
+    },
+    /** The width of the video in pixels. */
+    width: {
+      type: ParameterType.INT,
+      pretty_name: "Width",
+      default: "",
+    },
+    /** The height of the video display in pixels. */
+    height: {
+      type: ParameterType.INT,
+      pretty_name: "Height",
+      default: "",
+    },
+    /** If true, the video will begin playing as soon as it has loaded. */
+    autoplay: {
+      type: ParameterType.BOOL,
+      pretty_name: "Autoplay",
+      default: true,
+    },
+    /** If true, the subject will be able to pause the video or move the playback to any point in the video. */
+    controls: {
+      type: ParameterType.BOOL,
+      pretty_name: "Controls",
+      default: false,
+    },
+    /** Time to start the clip. If null (default), video will start at the beginning of the file. */
+    start: {
+      type: ParameterType.FLOAT,
+      pretty_name: "Start",
+      default: null,
+    },
+    /** Time to stop the clip. If null (default), video will stop at the end of the file. */
+    stop: {
+      type: ParameterType.FLOAT,
+      pretty_name: "Stop",
+      default: null,
+    },
+    /** The playback rate of the video. 1 is normal, <1 is slower, >1 is faster. */
+    rate: {
+      type: ParameterType.FLOAT,
+      pretty_name: "Rate",
+      default: 1,
+    },
+    /** If true, the trial will end immediately after the video finishes playing. */
+    trial_ends_after_video: {
+      type: ParameterType.BOOL,
+      pretty_name: "End trial after video finishes",
+      default: false,
+    },
+    /** How long to show trial before it ends. */
+    trial_duration: {
+      type: ParameterType.INT,
+      pretty_name: "Trial duration",
+      default: null,
+    },
+    /** If true, the trial will end when subject makes a response. */
+    response_ends_trial: {
+      type: ParameterType.BOOL,
+      pretty_name: "Response ends trial",
+      default: true,
+    },
+    /** If true, then responses are allowed while the video is playing. If false, then the video must finish playing before a response is accepted. */
+    response_allowed_while_playing: {
+      type: ParameterType.BOOL,
+      pretty_name: "Response allowed while playing",
+      default: true,
+    },
+    /** If true, multiple responses are recorded. If false, only the first response will be recorded. */
+    multiple_responses_allowed: {
+      type: ParameterType.BOOL,
+      pretty_name: "Multiple responses allowed",
+      default: true,
+    },
+  },
+};
+
+type Info = typeof info;
+
+/**
+ * **video-several-keyboard-responses**
+ *
+ * jsPsych plugin for playing a video file and getting several keyboard responses, based on @see {@link https://www.jspsych.org/plugins/jspsych-video-several-keyboard-responses/ video-several-keyboard-responses plugin documentation on jspsych.org}
+ *
+ * @author marianylund
+ * @see {@link https://www.jspsych.org/plugins/jspsych-video-several-keyboard-responses/ video-several-keyboard-responses plugin documentation on jspsych.org}
+ */
+class VideoSeveralKeyboardResponsesPlugin implements JsPsychPlugin<Info> {
+  static info = info;
+
+  constructor(private jsPsych: JsPsych) {}
+
+  trial(display_element: HTMLElement, trial: TrialType<Info>) {
+    // catch mistake where stimuli are not an array
+    if (!Array.isArray(trial.stimulus)) {
+      throw new Error(`
+        The stimulus property for the video-several-keyboard-responses plugin must be an array
+        of files. See https://www.jspsych.org/latest/plugins/video-several-keyboard-responses/#parameters
+      `);
+    }
+
+    // setup stimulus
+    var video_html = "<div>";
+    video_html += '<video id="jspsych-video-several-keyboard-responses-stimulus"';
+
+    if (trial.width) {
+      video_html += ' width="' + trial.width + '"';
+    }
+    if (trial.height) {
+      video_html += ' height="' + trial.height + '"';
+    }
+    if (trial.autoplay && trial.start == null) {
+      // if autoplay is true and the start time is specified, then the video will start automatically
+      // via the play() method, rather than the autoplay attribute, to prevent showing the first frame
+      video_html += " autoplay ";
+    }
+    if (trial.controls) {
+      video_html += " controls ";
+    }
+    if (trial.start !== null) {
+      // hide video element when page loads if the start time is specified,
+      // to prevent the video element from showing the first frame
+      video_html += ' style="visibility: hidden;"';
+    }
+    video_html += ">";
+
+    var video_preload_blob = this.jsPsych.pluginAPI.getVideoBuffer(trial.stimulus[0]);
+    if (!video_preload_blob) {
+      for (var i = 0; i < trial.stimulus.length; i++) {
+        var file_name = trial.stimulus[i];
+        if (file_name.indexOf("?") > -1) {
+          file_name = file_name.substring(0, file_name.indexOf("?"));
+        }
+        var type = file_name.substr(file_name.lastIndexOf(".") + 1);
+        type = type.toLowerCase();
+        if (type == "mov") {
+          console.warn(
+            "Warning: video-several-keyboard-responses plugin does not reliably support .mov files."
+          );
+        }
+        video_html += '<source src="' + file_name + '" type="video/' + type + '">';
+      }
+    }
+    video_html += "</video>";
+    video_html += "</div>";
+
+    // add prompt if there is one
+    if (trial.prompt !== null) {
+      video_html += trial.prompt;
+    }
+
+    display_element.innerHTML = video_html;
+
+    var video_element = display_element.querySelector<HTMLVideoElement>(
+      "#jspsych-video-several-keyboard-responses-stimulus"
+    );
+
+    if (video_preload_blob) {
+      video_element.src = video_preload_blob;
+    }
+
+    video_element.onended = () => {
+      if (trial.trial_ends_after_video) {
+        end_trial();
+      }
+      if (trial.response_allowed_while_playing == false && !trial.trial_ends_after_video) {
+        // start keyboard listener
+        var keyboardListener = this.jsPsych.pluginAPI.getKeyboardResponse({
+          callback_function: after_response,
+          valid_responses: trial.choices,
+          rt_method: "performance",
+          persist: false,
+          allow_held_key: false,
+        });
+      }
+    };
+
+    video_element.playbackRate = trial.rate;
+
+    // if video start time is specified, hide the video and set the starting time
+    // before showing and playing, so that the video doesn't automatically show the first frame
+    if (trial.start !== null) {
+      video_element.pause();
+      video_element.onseeked = () => {
+        video_element.style.visibility = "visible";
+        video_element.muted = false;
+        if (trial.autoplay) {
+          video_element.play();
+        } else {
+          video_element.pause();
+        }
+        video_element.onseeked = () => {};
+      };
+      video_element.onplaying = () => {
+        video_element.currentTime = trial.start;
+        video_element.onplaying = () => {};
+      };
+      // fix for iOS/MacOS browsers: videos aren't seekable until they start playing, so need to hide/mute, play,
+      // change current time, then show/unmute
+      video_element.muted = true;
+      video_element.play();
+    }
+
+    let stopped = false;
+    if (trial.stop !== null) {
+      video_element.addEventListener("timeupdate", (e) => {
+        var currenttime = video_element.currentTime;
+        if (currenttime >= trial.stop) {
+          if (!trial.response_allowed_while_playing) {
+            var keyboardListener = this.jsPsych.pluginAPI.getKeyboardResponse({
+              callback_function: after_response,
+              valid_responses: trial.choices,
+              rt_method: "performance",
+              persist: false,
+              allow_held_key: false,
+            });
+          }
+          video_element.pause();
+          if (trial.trial_ends_after_video && !stopped) {
+            // this is to prevent end_trial from being called twice, because the timeupdate event
+            // can fire in quick succession
+            stopped = true;
+            end_trial();
+          }
+        }
+      });
+    }
+
+    // store response
+    var response = {
+      rt: null,
+      key: null,
+      video_time: null
+    };
+
+    // function to end trial when it is time
+    const end_trial = () => {
+      // kill any remaining setTimeout handlers
+      this.jsPsych.pluginAPI.clearAllTimeouts();
+
+      // kill keyboard listeners
+      this.jsPsych.pluginAPI.cancelAllKeyboardResponses();
+
+      // stop the video file if it is playing
+      // remove end event listeners if they exist
+      display_element
+        .querySelector<HTMLVideoElement>("#jspsych-video-several-keyboard-responses-stimulus")
+        .pause();
+      display_element.querySelector<HTMLVideoElement>(
+        "#jspsych-video-several-keyboard-responses-stimulus"
+      ).onended = () => {};
+
+      // gather the data to store for the trial
+      var trial_data = {
+        rt: response.rt,
+        stimulus: trial.stimulus,
+        response: response.key,
+        video_time: response.video_time,
+      };
+
+      // clear the display
+      display_element.innerHTML = "";
+
+      // move on to the next trial
+      this.jsPsych.finishTrial(trial_data);
+    };
+
+    // function to handle responses by the subject
+    var after_response = (info) => {
+      // after a valid response, the stimulus will have the CSS class 'responded'
+      // which can be used to provide visual feedback that a response was recorded
+      display_element.querySelector("#jspsych-video-several-keyboard-responses-stimulus").className +=
+        " responded";
+
+      // by default only record the first response
+      if (response.key == null) {
+        if(!trial.multiple_responses_allowed){
+          // Would make sense to add it to a list, but then it would not be backwards compatible?
+          response = {rt: info.rt, key: info.key, video_time: video_element.currentTime,};
+        }else{
+          response = {rt: [info.rt], key: [info.key], video_time: [video_element.currentTime]};
+        }
+      }else if (trial.multiple_responses_allowed){
+        response.rt.push(info.rt);
+        response.key.push(info.key);
+        response.video_time.push(video_element.currentTime);
+      }
+
+      if (trial.response_ends_trial) {
+        end_trial();
+      }
+    };
+
+    // start the response listener
+    if (trial.choices != "NO_KEYS" && trial.response_allowed_while_playing) {
+      var keyboardListener = this.jsPsych.pluginAPI.getKeyboardResponse({
+        callback_function: after_response,
+        valid_responses: trial.choices,
+        rt_method: "performance",
+        persist: trial.multiple_responses_allowed,
+        allow_held_key: false,
+      });
+    }
+
+    // end trial if time limit is set
+    if (trial.trial_duration !== null) {
+      this.jsPsych.pluginAPI.setTimeout(end_trial, trial.trial_duration);
+    }
+  }
+
+  simulate(
+    trial: TrialType<Info>,
+    simulation_mode,
+    simulation_options: any,
+    load_callback: () => void
+  ) {
+    if (simulation_mode == "data-only") {
+      load_callback();
+      this.simulate_data_only(trial, simulation_options);
+    }
+    if (simulation_mode == "visual") {
+      this.simulate_visual(trial, simulation_options, load_callback);
+    }
+  }
+
+  private simulate_data_only(trial: TrialType<Info>, simulation_options) {
+    const data = this.create_simulation_data(trial, simulation_options);
+
+    this.jsPsych.finishTrial(data);
+  }
+
+  private simulate_visual(trial: TrialType<Info>, simulation_options, load_callback: () => void) {
+    const data = this.create_simulation_data(trial, simulation_options);
+
+    const display_element = this.jsPsych.getDisplayElement();
+
+    this.trial(display_element, trial);
+    load_callback();
+
+    const video_element = display_element.querySelector<HTMLVideoElement>(
+      "#jspsych-video-button-response-stimulus"
+    );
+
+    const respond = () => {
+      if (data.rt !== null) {
+        this.jsPsych.pluginAPI.pressKey(data.response, data.rt);
+      }
+    };
+
+    if (!trial.response_allowed_while_playing) {
+      video_element.addEventListener("ended", respond);
+    } else {
+      respond();
+    }
+  }
+
+  private create_simulation_data(trial: TrialType<Info>, simulation_options) {
+    const default_data = {
+      stimulus: trial.stimulus,
+      rt: this.jsPsych.randomization.sampleExGaussian(500, 50, 1 / 150, true),
+      response: this.jsPsych.pluginAPI.getValidKey(trial.choices),
+    };
+
+    const data = this.jsPsych.pluginAPI.mergeSimulationData(default_data, simulation_options);
+
+    this.jsPsych.pluginAPI.ensureSimulationDataConsistency(trial, data);
+
+    return data;
+  }
+}
+
+export default VideoSeveralKeyboardResponsesPlugin;
diff --git a/packages/plugin-video-several-keyboard-responses/tsconfig.json b/packages/plugin-video-several-keyboard-responses/tsconfig.json
new file mode 100644
index 00000000..3eabd0c2
--- /dev/null
+++ b/packages/plugin-video-several-keyboard-responses/tsconfig.json
@@ -0,0 +1,7 @@
+{
+  "extends": "@jspsych/config/tsconfig.contrib.json",
+  "compilerOptions": {
+    "baseUrl": "."
+  },
+  "include": ["src"]
+}

From 2dfc1606b2357049cad833d9839891f74f1353c7 Mon Sep 17 00:00:00 2001
From: Maria <mariaemnylund@gmail.com>
Date: Tue, 12 Dec 2023 11:35:04 +0100
Subject: [PATCH 2/5] Docs update

---
 README.md                                     |  1 +
 .../README.md                                 |  4 +--
 ...spsych-video-several-keyboard-responses.md | 36 +++++++++++++++++++
 3 files changed, 39 insertions(+), 2 deletions(-)
 create mode 100644 packages/plugin-video-several-keyboard-responses/docs/jspsych-video-several-keyboard-responses.md

diff --git a/README.md b/README.md
index 6e08a7bd..cfcb656d 100644
--- a/README.md
+++ b/README.md
@@ -38,6 +38,7 @@ Plugin/Extension | Contributor | Description
 [rdk](https://github.com/jspsych/jspsych-contrib/blob/main/packages/plugin-rdk/docs/jspsych-rdk.md#jspsych-rdk-plugin) | [Sivananda Rajananda](https://github.com/vrsivananda) | This plugin displays a Random Dot Kinematogram (RDK) and allows the subject to report the primary direction of motion by pressing a key on the keyboard.
 [rok](https://github.com/jspsych/jspsych-contrib/blob/main/packages/plugin-rok/docs/jspsych-rok.md#jspsych-rok-plugin) | [Younes Strittmatter](https://github.com/younesStrittmatter) | This plugin displays a Random Object Kinematogram (ROK) and allows the subject to report the primary direction of motion or the primary orientation by pressing a key on the keyboard.
 [self-paced-reading](https://github.com/jspsych/jspsych-contrib/blob/main/packages/plugin-self-paced-reading/docs/jspsych-self-paced-reading.md) | [@igmmgi](https://github.com/igmmgi) | Self-paced reading tasks with different display options.
+[video-several-keyboard-responses](https://github.com/jspsych/jspsych-contrib/blob/main/packages/plugin-video-several-keyboard-responses/docs/jspsych-video-several-keyboard-responses.md)|[@marianylund](https://github.com/marianylund) | This plugin is based on [video-keyboard-response](https://github.com/jspsych/jsPsych/tree/main/packages/plugin-video-keyboard-response) with possibility of recording multiple responses together with video timestamps.
 [vsl-animate-occlusion](https://github.com/jspsych/jspsych-contrib/blob/main/packages/plugin-vsl-animate-occlusion/docs/jspsych-vsl-animate-occlusion.md#jspsych-vsl-animate-occlusion-plugin) | [Josh de Leeuw](https://github.com/jodeleeuw) | The VSL (visual statistical learning) animate occlusion plugin displays an animated sequence of shapes that disappear behind an occluding rectangle while they change from one shape to another. 
 [vsl-grid-scene](https://github.com/jspsych/jspsych-contrib/blob/main/packages/plugin-vsl-grid-scene/docs/jspsych-vsl-grid-scene.md#jspsych-vsl-grid-scene-plugin) | [Josh de Leeuw](https://github.com/jodeleeuw) | The VSL (visual statistical learning) grid scene plugin displays images arranged in a grid. 
 
diff --git a/packages/plugin-video-several-keyboard-responses/README.md b/packages/plugin-video-several-keyboard-responses/README.md
index ef20c7cd..3ae03782 100644
--- a/packages/plugin-video-several-keyboard-responses/README.md
+++ b/packages/plugin-video-several-keyboard-responses/README.md
@@ -2,7 +2,7 @@
 
 ## Overview
 
-This plugin plays a video and records responses generated by the keyboard, similar to [plugin-video-keyboard-response](https://www.jspsych.org/latest/plugins/video-keyboard-response). The stimulus can be displayed until the end or for a pre-determined amount of time. In addition to responses and response times, the video time is saved when a response is given using a keyboard.
+This plugin plays a video and records responses generated by the keyboard, based on [plugin-video-keyboard-response](https://www.jspsych.org/latest/plugins/video-keyboard-response). The stimulus can be displayed until the end or for a pre-determined amount of time. In addition to responses and response times, the video time is saved when a response is given using a keyboard.
 
 ## Loading
 
@@ -24,7 +24,7 @@ import jsPsychVideoSeveralKeyboardResponses from '@jspsych-contrib/plugin-video-
 
 ## Compatibility
 
-jsPsych v7.0. 
+jsPsych v7.3.4
 
 ## Documentation
 
diff --git a/packages/plugin-video-several-keyboard-responses/docs/jspsych-video-several-keyboard-responses.md b/packages/plugin-video-several-keyboard-responses/docs/jspsych-video-several-keyboard-responses.md
new file mode 100644
index 00000000..59841700
--- /dev/null
+++ b/packages/plugin-video-several-keyboard-responses/docs/jspsych-video-several-keyboard-responses.md
@@ -0,0 +1,36 @@
+# jspsych-self-paced-reading plugin
+
+Based on [video-keyboard-response](https://github.com/jspsych/jsPsych/tree/main/packages/plugin-video-keyboard-response) plugin, this plugin allows playing video and recording multiple responses together with video timestamps.
+
+## Parameters
+
+In addition to the [parameters available in all plugins](https://www.jspsych.org/overview/plugins#parameters-available-in-all-plugins) and [video-keyboard-response](https://github.com/jspsych/jsPsych/blob/main/docs/plugins/video-keyboard-response.md) plugin, this plugin accepts the following parameters. Parameters with a default value of _undefined_ must be specified. Other parameters can be left unspecified if the default value is acceptable.
+
+| Parameter                  | Type | Default Value | Description                                                                                                                                    |
+| -------------------------- | ---- | ------------- | ---------------------------------------------------------------------------------------------------------------------------------------------- |
+| multiple_responses_allowed | bool | true          | If true, multiple responses are recorded. If false, only the first response will be recorded, thus behaving as video-keyboard-response plugin. |
+
+## Data Generated
+
+In addition to the [default data collected by all plugins](https://www.jspsych.org/overview/plugins#data-collected-by-all-plugins), this plugin collects the following data for each trial.
+
+| Name       | Type     | Value                                                            |
+| ---------- | -------- | ---------------------------------------------------------------- |
+| video_time | number[] | Array of playback positions of video when response was given (s) |
+
+## Example
+
+```javascript
+const trial = {
+  type: VideoSeveralKeyboardResponsesPlugin,
+  stimulus: ['video/sample_video.mp4'],
+  choices: "ALL_KEYS",
+  prompt: "Press any keys",
+  width: 600,
+  autoplay: true,
+  trial_ends_after_video: true,
+  response_ends_trial: false,
+  response_allowed_while_playing: true,
+  multiple_responses_allowed: true,
+};
+```

From f53784a6e54c16f5881b8a6a57a8ce20d15bee40 Mon Sep 17 00:00:00 2001
From: Maria <mariaemnylund@gmail.com>
Date: Tue, 12 Dec 2023 11:43:06 +0100
Subject: [PATCH 3/5] Added changeset

---
 .changeset/plugin-video-several-keyboard-responses.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/plugin-video-several-keyboard-responses.md

diff --git a/.changeset/plugin-video-several-keyboard-responses.md b/.changeset/plugin-video-several-keyboard-responses.md
new file mode 100644
index 00000000..246a9030
--- /dev/null
+++ b/.changeset/plugin-video-several-keyboard-responses.md
@@ -0,0 +1,5 @@
+---
+"@jspsych/plugin-video-several-keyboard-responses": major
+---
+
+Added video plugin based on video-keyboard-response plugin that allows for multiple responses and records video time

From 1a1a70252c91df8d26a2dfce017cc5f2b282bd4a Mon Sep 17 00:00:00 2001
From: Maria <mariaemnylund@gmail.com>
Date: Mon, 18 Dec 2023 10:32:06 +0100
Subject: [PATCH 4/5] Fixed tests

---
 .../src/index.spec.ts                                  | 10 +++++++---
 .../src/index.ts                                       |  1 +
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/packages/plugin-video-several-keyboard-responses/src/index.spec.ts b/packages/plugin-video-several-keyboard-responses/src/index.spec.ts
index f12246fe..8898d875 100644
--- a/packages/plugin-video-several-keyboard-responses/src/index.spec.ts
+++ b/packages/plugin-video-several-keyboard-responses/src/index.spec.ts
@@ -70,8 +70,12 @@ describe("video-several-keyboard-responses simulation", () => {
     jest.runAllTimers();
 
     await expectFinished();
-
-    expect(getData().values()[0].rt).toBeGreaterThan(0);
-    expect(typeof getData().values()[0].response).toBe("string");
+    
+    const rt = getData().values()[0].rt;
+    const response = getData().values()[0].response;
+    const video_time = getData().values()[0].video_time;
+    expect(rt.every(value => value > 0)).toBe(true);
+    expect(response.every(value => typeof value === "string")).toBe(true);
+    expect(video_time.every(value => typeof value === "number")).toBe(true);
   });
 });
diff --git a/packages/plugin-video-several-keyboard-responses/src/index.ts b/packages/plugin-video-several-keyboard-responses/src/index.ts
index 2deecbff..b5e7667a 100644
--- a/packages/plugin-video-several-keyboard-responses/src/index.ts
+++ b/packages/plugin-video-several-keyboard-responses/src/index.ts
@@ -381,6 +381,7 @@ class VideoSeveralKeyboardResponsesPlugin implements JsPsychPlugin<Info> {
       stimulus: trial.stimulus,
       rt: this.jsPsych.randomization.sampleExGaussian(500, 50, 1 / 150, true),
       response: this.jsPsych.pluginAPI.getValidKey(trial.choices),
+      video_time: 0,
     };
 
     const data = this.jsPsych.pluginAPI.mergeSimulationData(default_data, simulation_options);

From 816a010abc5cd735bfc636124696946d42e03b79 Mon Sep 17 00:00:00 2001
From: Maria <mariaemnylund@gmail.com>
Date: Mon, 18 Dec 2023 14:30:09 +0100
Subject: [PATCH 5/5] Added trial duration

---
 .../plugin-video-several-keyboard-responses/src/index.spec.ts    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/packages/plugin-video-several-keyboard-responses/src/index.spec.ts b/packages/plugin-video-several-keyboard-responses/src/index.spec.ts
index 8898d875..1d2ac515 100644
--- a/packages/plugin-video-several-keyboard-responses/src/index.spec.ts
+++ b/packages/plugin-video-several-keyboard-responses/src/index.spec.ts
@@ -53,6 +53,7 @@ describe("video-several-keyboard-responses simulation", () => {
         type: videoSeveralKeyboardResponses,
         stimulus: ["foo.mp4"],
         prompt: "foo",
+        trial_duration: 1000,
       },
     ];