Merge pull request #1 from jsr-core/improve

feat: allow mixed iterable in `chain` function
jsr-core · Aug 7, 2024 · 2f5ea63 · 2f5ea63
2 parents 27eef2a + 1091927
commit 2f5ea63
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/async/chain.ts b/async/chain.ts
@@ -14,7 +14,7 @@
  * ```
  */
 export async function* chain<T>(
-  ...iterables: Iterable<T>[] | AsyncIterable<T>[]
+  ...iterables: (Iterable<T> | AsyncIterable<T>)[]
 ): AsyncIterable<T> {
   for await (const iterable of iterables) {
     for await (const value of iterable) {

diff --git a/async/chain_test.ts b/async/chain_test.ts
@@ -22,4 +22,15 @@ Deno.test("chain", async (t) => {
     assertEquals(await toArray(result), expected);
     assertType<IsExact<typeof result, AsyncIterable<number>>>(true);
   });
+
+  await t.step("with mixed iterable", async () => {
+    const result = chain(
+      toAsyncIterable([1, 2]),
+      [3, 4],
+      toAsyncIterable([5]),
+    );
+    const expected = [1, 2, 3, 4, 5];
+    assertEquals(await toArray(result), expected);
+    assertType<IsExact<typeof result, AsyncIterable<number>>>(true);
+  });
 });