Added force option to skip prompting the user if they want files deleted #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsspencer
reviewed
Jul 1, 2022
| @@ -519,24 +521,28 @@ def diff_tests(tests, diff_program, verbose=1): | |||
| diff_popen.wait() | |||
| os.chdir(cwd) | |||
|
|
|||
| def tidy_tests(tests, ndays): | |||
| def tidy_tests(tests, ndays, force=False): | |||
There was a problem hiding this comment.
Nit: let's use a more meaningful name - force_deletion?
| while ans != 'y' and ans != 'n': | ||
| ans = testcode2.compatibility.compat_input('Confirm [y/n]: ') | ||
| if force: | ||
| ans = 'y' |
There was a problem hiding this comment.
Let's use a boolean flag here.
e.g.
if force_deletion:
delete_files = True
else:
...
delete_files = ans == 'y'
And then we have a clearer test in the next if block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to pass a --force flag which skips the confirmation message about deleting files. This is useful for makefile distclean options.